-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to force Nuget source and use local file paths with bootstrapper #1268
Conversation
If true, the Nuget download strategy is used, and no fallback strategy is provided; ignores the value of preferNuget. If false, continues existing evaluation, checking the preferNuget parameter.
If the `--force-nuget` command-line argument is supplied, or the `ForceNuget` setting exists in the application settings and is set to `true`, then the download strategy is set to only use the specified Nuget source. As the previous commit mentioned, if this CLA isn't specified and the app setting is either not present or not equal to `true`, the `--prefer-nuget` option is evaluated as it was before.
Will update again when I get `--nuget-source` working with file paths vs the nuget web API
|
@DavidHayden87 could you please review. thx |
|
Should work now as of 14b9b4c; still need to update the code for the bootstrapper to update itself with. |
|
@forki does it make sense to be checking the |
|
I guess nullorwhitespace would be better
|
|
I've pulled down the bootstrapper binary from AppVeyor and tried it in our case where we pull from an internal NuGet web server, and it all seems to still work. |
Since I've changed this code anyway, updating it to use this method covers a little more than just comparing against String.Empty.
|
@forki Just updated with changes to use @DavidHayden87 Thanks! |
Add options to force Nuget source and use local file paths with bootstrapper
Added a
--force-nugetcommand-line argument to the bootstrapper to getpaket.exefrom nuget rather than github, and to not automatically fallback to github as the--prefer-nugetoption does. Did this by just setting theFallbackStrategytonull, as the bootstrapper appears to already handle that here.Additional changes coming to allow using a local file path for the nuget source specified with
--nuget-source, rather than a web API.