Added ability to create symbol/source packages #1275

Merged
merged 9 commits into from Dec 2, 2015

Conversation

Projects
None yet
2 participants
@Haydabase
Contributor

Haydabase commented Dec 1, 2015

As per issue #868, I have added a symbols option to the pack command which will create symbol/source packages in addition to the regular packages, where for project templates.

Haydabase added some commits Dec 1, 2015

Fix xml getDescendants
Now returns the descendants of the node specified rather than
descendants of the root node
Fix coreProps root element
Changed from Relationships to coreProperties
#868 Added option to create symbols packages
Symbol/source packages can now be created by passing the symbols
argument to the pack command
src/Paket.Core/NupkgWriter.fs
@@ -141,7 +141,7 @@ let corePropsDoc (core : CompleteCoreInfo) =
let xsi = XNamespace.Get "http://www.w3.org/2001/XMLSchema-instance"
let root =
XElement
- (ns + "Relationships", XAttribute(XName.Get "xmlns", ns.NamespaceName),
+ (ns + "coreProperties", XAttribute(XName.Get "xmlns", ns.NamespaceName),

This comment has been minimized.

@forki

forki Dec 1, 2015

Member

is this correct? /cc @mavnn

@forki

forki Dec 1, 2015

Member

is this correct? /cc @mavnn

This comment has been minimized.

@Haydabase

Haydabase Dec 1, 2015

Contributor

I noticed this when comparing a package created with NuGet.exe vs. one created with Paket.exe, I'm assuming "Relationships" was a copy-paste error from the code for the .rels file.

@Haydabase

Haydabase Dec 1, 2015

Contributor

I noticed this when comparing a package created with NuGet.exe vs. one created with Paket.exe, I'm assuming "Relationships" was a copy-paste error from the code for the .rels file.

This comment has been minimized.

@forki

forki Dec 1, 2015

Member

ok so it's unrelated. could you please create a second PR with only this fix?

@forki

forki Dec 1, 2015

Member

ok so it's unrelated. could you please create a second PR with only this fix?

This comment has been minimized.

@Haydabase

Haydabase Dec 1, 2015

Contributor

Done #1276

@Haydabase

Haydabase Dec 1, 2015

Contributor

Done #1276

@Haydabase

This comment has been minimized.

Show comment
Hide comment
@Haydabase

Haydabase Dec 1, 2015

Contributor

@forki Is this pull request still being considered, or do I need to create a new one without the coreProps commit?

Contributor

Haydabase commented Dec 1, 2015

@forki Is this pull request still being considered, or do I need to create a new one without the coreProps commit?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 1, 2015

Member

no it's fine, but you can rebase this one if you like. but it's not that important

Member

forki commented Dec 1, 2015

no it's fine, but you can rebase this one if you like. but it's not that important

Haydabase added some commits Dec 1, 2015

Merge
# Conflicts:
#	src/Paket.Core/PackageProcess.fs
#	src/Paket.Core/PublicAPI.fs
Fix Merge
Bad merge with BuildPlatform changes
@Haydabase

This comment has been minimized.

Show comment
Hide comment
@Haydabase

Haydabase Dec 1, 2015

Contributor

I've done the non-trivial merge with other changes to the Pack command on master

Contributor

Haydabase commented Dec 1, 2015

I've done the non-trivial merge with other changes to the Pack command on master

forki added a commit that referenced this pull request Dec 2, 2015

Merge pull request #1275 from DavidHayden87/master
Added ability to create symbol/source packages

@forki forki merged commit 1048160 into fsprojects:master Dec 2, 2015

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@forki

This comment has been minimized.

Show comment
Hide comment
Member

forki commented Dec 2, 2015

goat

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 2, 2015

Member

could you please take a look at the docs and add a bit about this feature? thx

Member

forki commented Dec 2, 2015

could you please take a look at the docs and add a bit about this feature? thx

@Haydabase

This comment has been minimized.

Show comment
Hide comment
@Haydabase

Haydabase Dec 2, 2015

Contributor

Created pull request #1279 for the documentation

Contributor

Haydabase commented Dec 2, 2015

Created pull request #1279 for the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment