Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user prompts work with redirected stdin #1292

Merged
merged 2 commits into from Dec 6, 2015

Conversation

@Haydabase
Copy link
Contributor

@Haydabase Haydabase commented Dec 4, 2015

As per issue #1291, the prompt is now implemented with Console.ReadLine() which works with redirected standard input

The prompt is now implemented with Console.ReadLine() which works with
redirected standard input
@forki
Copy link
Member

@forki forki commented Dec 4, 2015

Should we clarify the questions, then?

@@ -280,7 +280,7 @@ let safeGetFromUrl (auth:Auth option, url : string, contentType : string) =
with _ -> return None
}

let readKey() = System.Console.ReadKey().KeyChar.ToString()
let readKey() = System.Console.ReadLine().Trim()

This comment has been minimized.

@forki

forki Dec 4, 2015
Member

should be renamed

This comment has been minimized.

@Haydabase

Haydabase Dec 5, 2015
Author Contributor

Fair enough, I've renamed to readAnswer

readKey was no longer an appropriate name since it now reads a whole
line
forki added a commit that referenced this pull request Dec 6, 2015
Make user prompts work with redirected stdin
@forki forki merged commit cd1ec7b into fsprojects:master Dec 6, 2015
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Haydabase Haydabase deleted the Haydabase:stdin-prompts branch Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.