Implement support for specifying per-template versions in paket pack #1314

Merged
merged 3 commits into from Dec 19, 2015

Conversation

Projects
None yet
3 participants
@eiriktsarpalis
Member

eiriktsarpalis commented Dec 18, 2015

This PR attempts to address the problem described in #1265. It incorporates the possibility to supply specific version numbers on a per-template basis:

paket pack version 1.1.2 specific-version Experimental.Lib 0.0.1-alpha specific-version Another.Experimental.Lib 1.0-beta

This has the behaviour of overriding the version number in specified template id's and ensures that this is reflected in wherever CURRENTVERSION is being replaced. When running the above command, the following file:

id Another.Experimental.Lib
dependencies
     Core.Lib CURRENTVERSION
     Experimental.Lib CURRENTVERSION

should generate a package equivalent to the template below:

id Another.Experimental.Lib
version 1.0-beta
dependencies
     Core.Lib 1.1.2
     Experimental.Lib 0.0.1-alpha

Please review. I will be posting a corresponding PR to the FAKE paket components to reflect this change.

@inosik

This comment has been minimized.

Show comment
Hide comment
@inosik

inosik Dec 18, 2015

Contributor

I like this 👍

I'm currently working on something, which would help us to keep the dependencies node out of paket.template, so we don't need to repeat what we might have in paket.references.

Look here for more.

Contributor

inosik commented Dec 18, 2015

I like this 👍

I'm currently working on something, which would help us to keep the dependencies node out of paket.template, so we don't need to repeat what we might have in paket.references.

Look here for more.

forki added a commit that referenced this pull request Dec 19, 2015

Merge pull request #1314 from eiriktsarpalis/custom-versions
Implement support for specifying per-template versions in paket pack

@forki forki merged commit a4bf87c into fsprojects:master Dec 19, 2015

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 19, 2015

Member

thx. and sorry that I didn't fix that other issue yet.

Member

forki commented Dec 19, 2015

thx. and sorry that I didn't fix that other issue yet.

@eiriktsarpalis

This comment has been minimized.

Show comment
Hide comment
@eiriktsarpalis

eiriktsarpalis Dec 19, 2015

Member

Thanks! I've updated my code to use the latest update. Here's what it looks like: mbraceproject/MBrace.Core@807eb2f#diff-6074983490330a0aac1bd23c958232d7R105

Member

eiriktsarpalis commented Dec 19, 2015

Thanks! I've updated my code to use the latest update. Here's what it looks like: mbraceproject/MBrace.Core@807eb2f#diff-6074983490330a0aac1bd23c958232d7R105

@eiriktsarpalis eiriktsarpalis deleted the eiriktsarpalis:custom-versions branch Dec 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment