Observable.flatten bugfix #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervable.flatten. This will fix a bug when observer.OnComplete never gets called in SearchPackagesByName operation.
forki
added a commit
that referenced
this pull request
Dec 28, 2015
|
thx for hunting down this bug. But the dependencies is very big, so I tried to fix it directly. Could you please review: afe98e4 thx |
|
@forki I got your point, I'll review (and test) that change tonight. Thanks for the answer. |
|
@forki yup that works very good (I've tried the latest releases Paket.VisualStudio version), and the code looks ok to me. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of
Observable.flattennever callsobs.OnComplete, and that leads to a bug in Paket.VisualStudio (and possibly adds problems for another users of this API).Instead of writing that method here (it could be difficult for a general case), I've decided to simply use
FSharp.Control.Reactiveinstead.This PR will close fsprojects/Paket.VisualStudio#60.
Please note that you'll have to include
FSharp.Control.Reactive.dllin a future builds of Paket.VisualStudio, and I've found that it's not trivial to achieve (because Paket.VisualStudio have no direct dependency on this package). In my local environment I got this fixed by adding reference to FSharp.Control.Reactive into a main Paket.VisualStudio assembly, but maybe there is some more conventional way.