Fixing problem with @ char in paths during pack (#1348) #1351

Merged
merged 2 commits into from Jan 6, 2016

Conversation

Projects
None yet
2 participants
@Vidarls
Contributor

Vidarls commented Jan 6, 2016

ref: #1348

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 6, 2016

Member

the travis fail is unrelated.
thx

Member

forki commented Jan 6, 2016

the travis fail is unrelated.
thx

+
+[<Test>]
+let ``#1235 npm type folder names`` () =

This comment has been minimized.

@forki

forki Jan 6, 2016

Member

Awesome.

@forki

forki Jan 6, 2016

Member

Awesome.

@Vidarls

This comment has been minimized.

Show comment
Hide comment
@Vidarls

Vidarls Jan 6, 2016

Contributor

ok, good. Was scratching my head severely now

Contributor

Vidarls commented Jan 6, 2016

ok, good. Was scratching my head severely now

@Vidarls

This comment has been minimized.

Show comment
Hide comment
@Vidarls

Vidarls Jan 6, 2016

Contributor

Quick question, what is the logic behind the # 1234 type naming in the integration tests? I just did the above test number +1, but now I am starting to think it might be references to github issues?

Contributor

Vidarls commented Jan 6, 2016

Quick question, what is the logic behind the # 1234 type naming in the integration tests? I just did the above test number +1, but now I am starting to think it might be references to github issues?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 6, 2016

Member

yep test name should be "#1348 ..."

Member

forki commented Jan 6, 2016

yep test name should be "#1348 ..."

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 6, 2016

Member

this allows us to find the issue from the test (when we break it in the future)

Member

forki commented Jan 6, 2016

this allows us to find the issue from the test (when we break it in the future)

@Vidarls

This comment has been minimized.

Show comment
Hide comment
@Vidarls

Vidarls Jan 6, 2016

Contributor

fixing...

Contributor

Vidarls commented Jan 6, 2016

fixing...

@Vidarls

This comment has been minimized.

Show comment
Hide comment
@Vidarls

Vidarls Jan 6, 2016

Contributor

fixed

Contributor

Vidarls commented Jan 6, 2016

fixed

forki added a commit that referenced this pull request Jan 6, 2016

Merge pull request #1351 from Vidarls/foldernames
Fixing problem with @ char in paths during pack (#1348)

@forki forki merged commit 5a25871 into fsprojects:master Jan 6, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment