NuGetV2: avoid revealing password also if more than one source is defined #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrnet
changed the title
|
ouch. thx |
forki
added a commit
that referenced
this pull request
Jan 8, 2016
NuGetV2: avoid revealing password also if more than one source is defined
|
Great, thanks! |
|
Thanks for solving this! We are then going to adopt Paket in our company 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor regression on the fix from #1238 to protect personal passwords from being revealed in logs and the shell. In case of multiple sources it fell back to the original unprocessed
sourcesand thus bypass theToStringoverride.