Symbols source

[pms1969]

changed the way I thought about the problem.... now works much better, and the build.cmd nuget command should work as expected.

[pms1969]

is this ok?

[forki]

I had to resolve merge conflicts since @cloudRoutine send it some refactorings in that area.
please review dc7ec47

thx

[pms1969]

doh, just spotted a problem with it (linked files). I'll fix asap (might be early tomorrow) and get you another pull request.

[forki]

Cool thx
On Jan 14, 2016 20:46, "Paul Saunders" notifications@github.com wrote:

doh, just spotted a problem with it (linked files). I'll fix asap (might
be early tomorrow) and get you another pull request.

—
Reply to this email directly or view it on GitHub
#1383 (comment).

[harrisonmeister]

Can I ask why this has been done? I now have a bunch of internal nuget packages which have their dependencies added, which makes for larger internal nuget packages

[forki]

Really? I thought it was under switch and only for symbol packages

[forki]

Could please elaborate a bit on the concrete issue?

[harrisonmeister]

By symbol packages, do you mean project references? That's what I'm seeing. When I run a paket hard install, I get the Dependency twice, e.g.:

ProjectB has a project reference to ProjectA. When I reference ProjectB in some other project, say ProjectC, I see the below - which seems odd that it would appear twice. (It might be that this is right)

<Choose>
    <When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.0' Or $(TargetFrameworkVersion) == 'v4.5')">
      <ItemGroup>
        <Reference Include="ProjectA">
          <HintPath>..\..\..\..\packages\ProjectA\lib\net40\ProjectA.dll</HintPath>
          <Private>True</Private>
          <Paket>True</Paket>
        </Reference>
      </ItemGroup>
    </When>
  </Choose>
  <Choose>
    <When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.0' Or $(TargetFrameworkVersion) == 'v4.5')">
      <ItemGroup>
        <Reference Include="ProjectA">
          <HintPath>..\..\..\..\packages\ProjectB\lib\net40\ProjectA.dll</HintPath>
          <Private>True</Private>
          <Paket>True</Paket>
        </Reference>
        <Reference Include="ProjectB">
          <HintPath>..\..\..\..\packages\ProjectB\lib\net40\ProjectB.dll</HintPath>
          <Private>True</Private>
          <Paket>True</Paket>
        </Reference>
      </ItemGroup>
    </When>
  </Choose>

[forki]

ProjectA.dll shouldn't be in Project B nuget package. that is clearly a bug.

I think https://github.com/fsprojects/Paket/pull/1383/files#diff-74c1bcac29cb19f058c1e6032cc1ce19R161 needs to be filtered. we should not add that stuff when a paket.template file exists for that project

[forki]

could you please retry?

[forki]

with latest that is..

[harrisonmeister]

Hi, sure will let you know the results

[harrisonmeister]

Looks like thats fixed it, many thanks!

[pms1969]

good spot. Sorry I missed that.