pdb's no longer being packaged in the non symbols package #1403

Merged
merged 2 commits into from Jan 18, 2016

Conversation

Projects
None yet
2 participants
@pms1969
Contributor

pms1969 commented Jan 18, 2016

No description provided.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 18, 2016

Member

Why that change?

Member

forki commented Jan 18, 2016

Why that change?

@pms1969

This comment has been minimized.

Show comment
Hide comment
@pms1969

pms1969 Jan 18, 2016

Contributor

#1394

basically, if the pdb's are in the non-symbols package, VS won't download the symbols package for debugging.

Contributor

pms1969 commented Jan 18, 2016

#1394

basically, if the pdb's are in the non-symbols package, VS won't download the symbols package for debugging.

@pms1969

This comment has been minimized.

Show comment
Hide comment
@pms1969

pms1969 Jan 18, 2016

Contributor

as far as I can tell, the Travis build was already borking on that test.

Contributor

pms1969 commented Jan 18, 2016

as far as I can tell, the Travis build was already borking on that test.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 18, 2016

Member

So now we put the pdbs in the normal package, but not into the symbols
package?
On Jan 18, 2016 8:47 AM, "Paul Saunders" notifications@github.com wrote:

#1394 #1394

basically, if the pdb's are in the non-symbols package, VS won't download
the symbols package for debugging.


Reply to this email directly or view it on GitHub
#1403 (comment).

Member

forki commented Jan 18, 2016

So now we put the pdbs in the normal package, but not into the symbols
package?
On Jan 18, 2016 8:47 AM, "Paul Saunders" notifications@github.com wrote:

#1394 #1394

basically, if the pdb's are in the non-symbols package, VS won't download
the symbols package for debugging.


Reply to this email directly or view it on GitHub
#1403 (comment).

@pms1969

This comment has been minimized.

Show comment
Hide comment
@pms1969

pms1969 Jan 18, 2016

Contributor

Other way around.

Contributor

pms1969 commented Jan 18, 2016

Other way around.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 18, 2016

Member

But not everyone is using symbols packages. What about the other case?
On Jan 18, 2016 8:51 AM, "Paul Saunders" notifications@github.com wrote:

Other way around.


Reply to this email directly or view it on GitHub
#1403 (comment).

Member

forki commented Jan 18, 2016

But not everyone is using symbols packages. What about the other case?
On Jan 18, 2016 8:51 AM, "Paul Saunders" notifications@github.com wrote:

Other way around.


Reply to this email directly or view it on GitHub
#1403 (comment).

@pms1969

This comment has been minimized.

Show comment
Hide comment
@pms1969

pms1969 Jan 18, 2016

Contributor

depends if you want strict nuget replication in that area or not. Nuget doesn't package them in the non-symbols regardless.

Should only require a small tweak to fix for when there is no symbols requested. Depends on what you'd like to do?

Contributor

pms1969 commented Jan 18, 2016

depends if you want strict nuget replication in that area or not. Nuget doesn't package them in the non-symbols regardless.

Should only require a small tweak to fix for when there is no symbols requested. Depends on what you'd like to do?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 18, 2016

Member

I think we should still put the pdbs in the normal package when we don't
create a symbols package. That's what nuget does, right?
On Jan 18, 2016 9:05 AM, "Paul Saunders" notifications@github.com wrote:

depends if you want strict nuget replication in that area or not. Nuget
doesn't package them in the non-symbols regardless.

Should only require a small tweak to fix for when there is no symbols
requested. Depends on what you'd like to do?


Reply to this email directly or view it on GitHub
#1403 (comment).

Member

forki commented Jan 18, 2016

I think we should still put the pdbs in the normal package when we don't
create a symbols package. That's what nuget does, right?
On Jan 18, 2016 9:05 AM, "Paul Saunders" notifications@github.com wrote:

depends if you want strict nuget replication in that area or not. Nuget
doesn't package them in the non-symbols regardless.

Should only require a small tweak to fix for when there is no symbols
requested. Depends on what you'd like to do?


Reply to this email directly or view it on GitHub
#1403 (comment).

@pms1969

This comment has been minimized.

Show comment
Hide comment
@pms1969

pms1969 Jan 18, 2016

Contributor

No it doesn't, tho i'll confirm that.

In the case that you want to add them, you can still add it as a file dependency and it won't be removed. (I've just confirmed that that is true of that build)

Contributor

pms1969 commented Jan 18, 2016

No it doesn't, tho i'll confirm that.

In the case that you want to add them, you can still add it as a file dependency and it won't be removed. (I've just confirmed that that is true of that build)

@pms1969

This comment has been minimized.

Show comment
Hide comment
@pms1969

pms1969 Jan 18, 2016

Contributor

Confirmed. Nuget does not include pdb's regardless of whether symbols have been requested or not.

Contributor

pms1969 commented Jan 18, 2016

Confirmed. Nuget does not include pdb's regardless of whether symbols have been requested or not.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 18, 2016

Member

Ok. Let's remove them then. But how about a template file property that
automatically adds them? Should be a good alternative for people so they
don't have to use explicit file references
On Jan 18, 2016 9:17 AM, "Paul Saunders" notifications@github.com wrote:

Confirmed. Nuget does not include pdb's regardless of whether symbols have
been requested or not.


Reply to this email directly or view it on GitHub
#1403 (comment).

Member

forki commented Jan 18, 2016

Ok. Let's remove them then. But how about a template file property that
automatically adds them? Should be a good alternative for people so they
don't have to use explicit file references
On Jan 18, 2016 9:17 AM, "Paul Saunders" notifications@github.com wrote:

Confirmed. Nuget does not include pdb's regardless of whether symbols have
been requested or not.


Reply to this email directly or view it on GitHub
#1403 (comment).

@pms1969

This comment has been minimized.

Show comment
Hide comment
@pms1969

pms1969 Jan 18, 2016

Contributor

not a bad idea? so for project files only?
property: include-pdbs
default: false
??

meaningless for file templates.

Contributor

pms1969 commented Jan 18, 2016

not a bad idea? so for project files only?
property: include-pdbs
default: false
??

meaningless for file templates.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 18, 2016

Member

yes that would be awesome

Member

forki commented Jan 18, 2016

yes that would be awesome

@pms1969

This comment has been minimized.

Show comment
Hide comment
@pms1969

pms1969 Jan 18, 2016

Contributor

do you want that as part of this pull request or another?

Contributor

pms1969 commented Jan 18, 2016

do you want that as part of this pull request or another?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 18, 2016

Member

please add it to this one.

Member

forki commented Jan 18, 2016

please add it to this one.

@pms1969

This comment has been minimized.

Show comment
Hide comment
@pms1969

pms1969 Jan 18, 2016

Contributor

done

Contributor

pms1969 commented Jan 18, 2016

done

@pms1969

This comment has been minimized.

Show comment
Hide comment
@pms1969

pms1969 Jan 18, 2016

Contributor

travis failing on the same tests. It has an ignore on it, so not sure why it gets run.

Contributor

pms1969 commented Jan 18, 2016

travis failing on the same tests. It has an ignore on it, so not sure why it gets run.

forki added a commit that referenced this pull request Jan 18, 2016

Merge pull request #1403 from pms1969/fix-pdbs
pdb's no longer being packaged in the non symbols package

@forki forki merged commit c410e75 into fsprojects:master Jan 18, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@pms1969 pms1969 deleted the pms1969:fix-pdbs branch Jan 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment