fix convert-from-nuget #1437

Merged
merged 2 commits into from Jan 28, 2016

Conversation

Projects
None yet
2 participants
@pms1969
Contributor

pms1969 commented Jan 27, 2016

found the reason the packages.configs weren't being changed to paket.references in the project files.

seems I inadvertently changed a line during one of my commits. :-s

Paul Saunders
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 27, 2016

Member

I'd love to see a mini integration test to nail this one down. Can you please give it a try?

Member

forki commented Jan 27, 2016

I'd love to see a mini integration test to nail this one down. Can you please give it a try?

@pms1969

This comment has been minimized.

Show comment
Hide comment
@pms1969

pms1969 Jan 27, 2016

Contributor

sure, might have to wait till later tonight

Contributor

pms1969 commented Jan 27, 2016

sure, might have to wait till later tonight

@pms1969

This comment has been minimized.

Show comment
Hide comment
@pms1969

pms1969 Jan 27, 2016

Contributor

done

Contributor

pms1969 commented Jan 27, 2016

done

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 27, 2016

Member

Ah so we already had test data but an assertion was missing?

Thanks

Member

forki commented Jan 27, 2016

Ah so we already had test data but an assertion was missing?

Thanks

@pms1969

This comment has been minimized.

Show comment
Hide comment
@pms1969

pms1969 Jan 27, 2016

Contributor

yes.

no probs

Contributor

pms1969 commented Jan 27, 2016

yes.

no probs

forki added a commit that referenced this pull request Jan 28, 2016

@forki forki merged commit e06b8e3 into fsprojects:master Jan 28, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 28, 2016

Member

thx

Member

forki commented Jan 28, 2016

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment