New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore: optional --touch-affected-refs to touch refs affected by a restore #1485

Merged
merged 1 commit into from Feb 29, 2016

Conversation

Projects
None yet
2 participants
@cdrnet
Member

cdrnet commented Feb 22, 2016

Proposal how #1471 could be addressed, to help incremental build tools like MsBuild to detect the need to rebuild selective projects.

I'm not convinced Project.save true is the right approach though, since it could also affect the content of the project file. Maybe we should specifically add a Project.touch instead which guarantees the project file content remains exactly the same?

@cdrnet cdrnet changed the title from Restore: optional --touch-affected-refs to touch refs affected by a restore to [WIP] Restore: optional --touch-affected-refs to touch refs affected by a restore Feb 22, 2016

@cdrnet cdrnet changed the title from [WIP] Restore: optional --touch-affected-refs to touch refs affected by a restore to Restore: optional --touch-affected-refs to touch refs affected by a restore Feb 22, 2016

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Feb 29, 2016

Member

Project.touch sound s like a good change

Member

forki commented Feb 29, 2016

Project.touch sound s like a good change

forki added a commit that referenced this pull request Feb 29, 2016

Merge pull request #1485 from cdrnet/touch-affected-project-files
Restore: optional --touch-affected-refs to touch refs affected by a restore

@forki forki merged commit 347176c into fsprojects:master Feb 29, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cdrnet cdrnet deleted the cdrnet:touch-affected-project-files branch Mar 1, 2016

forki pushed a commit that referenced this pull request Mar 1, 2016

ProjectFile.touch to only modify the last write time without changing…
… file content

This is a follow up to #1485 which introduced the optional --touch-affected-refs
parameter on restore. In the original implementation this caused the
project file to be saved forcefully, which could in some cases cause the
file content to change slightly (e.g. minor xml formatting).

With this change, the only effect of --touch-affected-refs will be a
modified last-write time file attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment