New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct src folder structure for packing with symbols #1538

Merged
merged 1 commit into from Mar 23, 2016

Conversation

Projects
None yet
2 participants
@kevinbosman
Contributor

kevinbosman commented Mar 22, 2016

Packing a NuGet package with symbols generates the incorrect src folder structure within the symbols.nupkg file, which prevents the source from being found when querying the symbolsource server.

This PR adds an integration test with a few examples in a new scenario, and fixes the problem.

The fixed symbols package has been tested to be working correctly on our local ProGet symbols server from Visual Studio 2015.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Mar 22, 2016

Member

don't worry about the broken test. I'm playing with something

Member

forki commented Mar 22, 2016

don't worry about the broken test. I'm playing with something

@kevinbosman

This comment has been minimized.

Show comment
Hide comment
@kevinbosman

kevinbosman Mar 22, 2016

Contributor

Cool thanks, it was timing out on Travis only, so I kicked off another build...

Contributor

kevinbosman commented Mar 22, 2016

Cool thanks, it was timing out on Travis only, so I kicked off another build...

@forki forki merged commit 0615c37 into fsprojects:master Mar 23, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@kevinbosman kevinbosman deleted the kevinbosman:symbols-src-folders branch Mar 23, 2016

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Mar 23, 2016

Member

sorry didn't see that. there was indeed a broken test here. "#1538 symbols src folder structure" doesn't work on mono. could you please look again?

Member

forki commented Mar 23, 2016

sorry didn't see that. there was indeed a broken test here. "#1538 symbols src folder structure" doesn't work on mono. could you please look again?

@kevinbosman

This comment has been minimized.

Show comment
Hide comment
@kevinbosman

kevinbosman Mar 23, 2016

Contributor

Will do...

Contributor

kevinbosman commented Mar 23, 2016

Will do...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment