Property Definitions: placed after non-paket imports if they directly follow the top property groups

[cdrnet]

Related to #1537

If in a project file there are non-paket imports right after the top property groups, then place the property definitions right after them (instead of before them). This makes sure that imports like Microsoft.CSharp.targets can be moved up before them, to make sureTargetFrameworkIdentifier is actually defined. Note that it does not move Microsoft.CSharp.targets up manually if it is further down (which it is by default).

[cdrnet]

Should I rather have created/forked a new integration test instead of changing existing ones?

[forki]

Yeah more tests are probably better
On Mar 30, 2016 10:40 AM, "Christoph Ruegg" notifications@github.com
wrote:

Should I rather have created/forked a new integration test instead of
changing existing ones?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1561 (comment)

[forki]

but I think it's fine

[cdrnet]

Note that in the quite common case that Microsoft.CSharp.targets is further down this change will only allow to manually fix it by moving it up (and make the fix survive paket operations), but will not actually fix it itself.

Should we try to be smarter? Being smart could easily break other stuff unfortunately.

[forki]

I think we should wait and see what happens - also in regards to #1562