New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: support combining filter with specific version #1580

Merged
merged 2 commits into from Apr 7, 2016

Conversation

Projects
None yet
2 participants
@cdrnet
Member

cdrnet commented Apr 7, 2016

Update supports updating all packages matching a regex. It also supports providing a specific version to update to. What it did not support before is combining these two, i.e. updating all packages matching a regex to the same specific version. This PR adds the missing piece to support this combination.

@cdrnet

This comment has been minimized.

Show comment
Hide comment
@cdrnet

cdrnet Apr 7, 2016

Member

NB: the matching logic seems somewhat risky to me, there is a chance for collisions with argument/option keywords. Isn't "nuget" required to be the first (index 0) and the package name the second token (index 1) for nuget dependencies, provided we specify StringSplitOptions.RemoveEmptyEntries?

Member

cdrnet commented Apr 7, 2016

NB: the matching logic seems somewhat risky to me, there is a chance for collisions with argument/option keywords. Isn't "nuget" required to be the first (index 0) and the package name the second token (index 1) for nuget dependencies, provided we specify StringSplitOptions.RemoveEmptyEntries?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 7, 2016

Member

yeah. can you fix that as well?

Member

forki commented Apr 7, 2016

yeah. can you fix that as well?

@cdrnet

This comment has been minimized.

Show comment
Hide comment
@cdrnet

cdrnet Apr 7, 2016

Member

One integration test failed with a timed out (#1371 without download fail). Could this be related to my change?

Member

cdrnet commented Apr 7, 2016

One integration test failed with a timed out (#1371 without download fail). Could this be related to my change?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 7, 2016

Member

probably not. that one is flaky.

Member

forki commented Apr 7, 2016

probably not. that one is flaky.

@forki forki merged commit 83cc7b5 into fsprojects:master Apr 7, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 7, 2016

Member

thanks a lot

Member

forki commented Apr 7, 2016

thanks a lot

@cdrnet cdrnet deleted the cdrnet:update-filter-version branch Apr 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment