New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow empty string as authors and description metadata #1728

Merged
merged 3 commits into from Jun 16, 2016

Conversation

Projects
None yet
2 participants
@inosik
Contributor

inosik commented Jun 15, 2016

Paket produces invalid metadata for packages, which only have type project in their paket.template file.

Those packages look ok, but cause problems further down the road, i. e. when trying to upload them or when using test adapters installed via Paket. Probably when trying to install them with NuGet, too, because the non-descriptive error message in VS comes from NuGet.Core.

/cc @biehlermi

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 15, 2016

Member

could you pelase take a look at the broken test? thanks

Member

forki commented Jun 15, 2016

could you pelase take a look at the broken test? thanks

@inosik

This comment has been minimized.

Show comment
Hide comment
@inosik

inosik Jun 15, 2016

Contributor

Missed that one, should pass now.

Contributor

inosik commented Jun 15, 2016

Missed that one, should pass now.

@inosik

This comment has been minimized.

Show comment
Hide comment
@inosik

inosik Jun 15, 2016

Contributor

An integration test for paket update timed out on Mono, not related to this.

Contributor

inosik commented Jun 15, 2016

An integration test for paket update timed out on Mono, not related to this.

@forki forki merged commit 08b7d3b into fsprojects:master Jun 16, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 16, 2016

Member

Thanks. This is now in v 3.1

Member

forki commented Jun 16, 2016

Thanks. This is now in v 3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment