New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore case in aliases dll names #1733

Merged
merged 1 commit into from Jun 16, 2016

Conversation

Projects
None yet
2 participants
@vbfox
Contributor

vbfox commented Jun 16, 2016

The previous code was expecting the passed in name to be a lowercase substring of the dll file name. It's now expected to be the full name (not a substring) but allow the case to differ.

Fixes #1732

Ignore case in aliases dll names
The previous code was expecting the passed in name to be a lowercase
substring of the dll file name. It's now expected to be the full name (not
a substring) but allow the case to differ.

Fixes #1732

@vbfox vbfox closed this Jun 16, 2016

@vbfox

This comment has been minimized.

Show comment
Hide comment
@vbfox

vbfox Jun 16, 2016

Contributor

Oops binary files, i'll remove & rebase.

Contributor

vbfox commented Jun 16, 2016

Oops binary files, i'll remove & rebase.

@vbfox vbfox reopened this Jun 16, 2016

@vbfox

This comment has been minimized.

Show comment
Hide comment
@vbfox

vbfox Jun 16, 2016

Contributor

Actually let's reopen this PR, I don't know what's the policy @forki

The files are the same as the previous test so don't really take space in git, but I don't know why the files were present in the other one. To accelerate the tests ? to ensure that it's working if nuget remove the old versions ?

(I have no problem changing the PR to not have them)

Contributor

vbfox commented Jun 16, 2016

Actually let's reopen this PR, I don't know what's the policy @forki

The files are the same as the previous test so don't really take space in git, but I don't know why the files were present in the other one. To accelerate the tests ? to ensure that it's working if nuget remove the old versions ?

(I have no problem changing the PR to not have them)

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 16, 2016

Member

they are there to keep things stable.

Member

forki commented Jun 16, 2016

they are there to keep things stable.

@forki forki merged commit 6bf1099 into fsprojects:master Jun 16, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 16, 2016

Member

thanks!

Member

forki commented Jun 16, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment