New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add condition to AfterBuild target to unbreak nCrunch #1734

Merged
merged 2 commits into from Jun 16, 2016

Conversation

Projects
None yet
3 participants
@thinkbeforecoding

thinkbeforecoding commented Jun 16, 2016

NCrunch doesn't run well with the target that is generated with some projects.
Adding a condition to the target disable it when running under ncrunch, avoiding to break compilation.

@smoothdeveloper

This comment has been minimized.

Show comment
Hide comment
@smoothdeveloper

smoothdeveloper Jun 16, 2016

Contributor

@thinkbeforecoding could you add a failing (without the change) integration test as well?

Thanks!

Contributor

smoothdeveloper commented Jun 16, 2016

@thinkbeforecoding could you add a failing (without the change) integration test as well?

Thanks!

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 16, 2016

Member

there is actually already a broken test. so @thinkbeforecoding can you please try to fix that one?

Member

forki commented Jun 16, 2016

there is actually already a broken test. so @thinkbeforecoding can you please try to fix that one?

@forki forki merged commit d7dc283 into fsprojects:master Jun 16, 2016

1 check failed

continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
@thinkbeforecoding

This comment has been minimized.

Show comment
Hide comment
@thinkbeforecoding

thinkbeforecoding Jun 16, 2016

I'm discovering the IntegrationTests so I'll try to see where it breaks

thinkbeforecoding commented Jun 16, 2016

I'm discovering the IntegrationTests so I'll try to see where it breaks

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 16, 2016

Member

I'm already on it
On Jun 16, 2016 4:42 PM, "Jérémie Chassaing" notifications@github.com
wrote:

I'm discovering the IntegrationTests so I'll try to see where it breaks


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#1734 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADgNAhbIONr1W_4jZ_LOvFe5qsyjiM_ks5qMWDSgaJpZM4I3XZo
.

Member

forki commented Jun 16, 2016

I'm already on it
On Jun 16, 2016 4:42 PM, "Jérémie Chassaing" notifications@github.com
wrote:

I'm discovering the IntegrationTests so I'll try to see where it breaks


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#1734 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADgNAhbIONr1W_4jZ_LOvFe5qsyjiM_ks5qMWDSgaJpZM4I3XZo
.

@thinkbeforecoding

This comment has been minimized.

Show comment
Hide comment
@thinkbeforecoding

thinkbeforecoding Jun 16, 2016

I think it's in a test where the condition has been added and the test verify equality with exising project. The project should then be updated.

thinkbeforecoding commented Jun 16, 2016

I think it's in a test where the condition has been added and the test verify equality with exising project. The project should then be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment