New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify works with auto-detected target frameworks #1740

Merged
merged 1 commit into from Jun 19, 2016

Conversation

Projects
None yet
2 participants
@baronfel
Contributor

baronfel commented Jun 19, 2016

This PR fixes #1737 by changing the logic of DependenciesFile.SimplifyFrameworkRestrictions so that it no longer called a helper method that threw and exception when the framework is auto-detected. Instead, we use the ProjectFile type and members of the ProjectFile module to get the list of distinct targetframeworkversions, similar to what is already done in other pathways.

To make it work I had to split up DependenciesFile into several smaller files, so that the ordering was such that the actual implementation of DependenciesFile came after ProjectFile.

I included a passing integration test to show the new functionality works.

update simplify to property generate the list of targetframework rest…
…rictions when the framework is being auto-detected
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 19, 2016

Member

thanks!

Member

forki commented Jun 19, 2016

thanks!

@forki forki merged commit 41af538 into fsprojects:master Jun 19, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment