fix #1741 by trying to repair the file paths and writing a warning. #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if newName.Contains "..\\" then | ||
| failwithf "Relative paths are not supported. Please tell the package author to fix the package to not use relative paths. The invalid file was '%s'" file.FullName | ||
| if newName.Contains "\\" then | ||
| traceWarnfn "File '%s' contains backslashes, probably because it wasn't properly packaged (for example with windows paths in nuspec on a unix like system). Please tell the package author to fix it." file.FullName |
There was a problem hiding this comment.
If people start to complain about the new warnings you can remove this line (but I don't think they will as they would have noticed by now that paket3 wasn't working).
|
O wow you can use |
|
;-) thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree with trying to fix the package, but while starting to implement option 3, I think there is a problem. People can call their file
%2e%2e%5c%2e%2e%5ctest(= ....\test) and make paket write anywhere. It shouldn't be more security relevant than using a type provider but I don't the idea of people depending on something like that therefore I tried to prevent it.