Pack localized assemblies. #1807
Conversation
| let includeattribute = "Include" | ||
| this.ProjectNode | ||
| |> getDescendants "EmbeddedResource" | ||
| |> List.filter (fun n -> n |> hasAttribute includeattribute) |
There was a problem hiding this comment.
why not point free?
There was a problem hiding this comment.
What does it mean?
There was a problem hiding this comment.
means (fun n -> n |> hasAttribute includeattribute) is the same as (hasAttribute includeattribute)
JohanLarsson
force-pushed
the
pr_1806
branch
3 times, most recently
from
16c773d
to
d935beb
Compare
|
Awesome! Only one important thing left: docs. ;-) Could you please add a small bit about this auto-packing of satelitte assemblies? |
|
|
||
| let template = | ||
| satelliteDlls | ||
| |> Seq.fold (fun template dll -> addFile (fst dll).FullName (snd dll) template) template |
There was a problem hiding this comment.
you could decompose dll here:
|> Seq.fold (fun template (dllFile, targetDir) -> addFile dllFile.FullName targetDir template) templateThere was a problem hiding this comment.
Nice, I was stuck on that one for a while, used a fuzzying process.
|
@forki updated with a mention in docs. |
|
mhmm looks like it's broken on mono. can you please take a look? |
|
we also got a regression, so I reverted that change for now. see #1810 |
|
I'll be mostly afk for a couple of days. Checking as soon as I can. Maybe outputting a warning is better than throwing if satellite dll is not found. |
An attempt at #1806