New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose license url in public namespace #1811

Merged
merged 1 commit into from Jul 14, 2016

Conversation

Projects
None yet
2 participants
@robertpi
Contributor

robertpi commented Jul 14, 2016

Conflicts:
src/Paket.Core/InstallModel.fs

Expose license url in public namespace
Conflicts:
	src/Paket.Core/InstallModel.fs
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jul 14, 2016

Member

what's the purpose of this?

Member

forki commented Jul 14, 2016

what's the purpose of this?

@robertpi

This comment has been minimized.

Show comment
Hide comment
@robertpi

robertpi Jul 14, 2016

Contributor

It adds LicenseUrl to type InstallModel, I needed it in the public api,
I thought others might too.

On Thu, Jul 14, 2016, at 01:23 PM, Steffen Forkmann wrote:

what's the prupose of this?
— You are receiving this because you authored the thread. Reply to
this email directly, view it on GitHub[1], or mute the thread[2].

 

Links:

  1. #1811 (comment)
  2. https://github.com/notifications/unsubscribe/AADItVLI8bbhQqFrxCfU6ZXtxy7TonHTks5qVhw1gaJpZM4JMVKg
Contributor

robertpi commented Jul 14, 2016

It adds LicenseUrl to type InstallModel, I needed it in the public api,
I thought others might too.

On Thu, Jul 14, 2016, at 01:23 PM, Steffen Forkmann wrote:

what's the prupose of this?
— You are receiving this because you authored the thread. Reply to
this email directly, view it on GitHub[1], or mute the thread[2].

 

Links:

  1. #1811 (comment)
  2. https://github.com/notifications/unsubscribe/AADItVLI8bbhQqFrxCfU6ZXtxy7TonHTks5qVhw1gaJpZM4JMVKg
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jul 14, 2016

Member

Ok. It looks reasonable

On Jul 14, 2016 2:03 PM, "Robert Pickering" notifications@github.com
wrote:

It adds LicenseUrl to type InstallModel, I needed it in the public api,
I thought others might too.

On Thu, Jul 14, 2016, at 01:23 PM, Steffen Forkmann wrote:

what's the prupose of this?
— You are receiving this because you authored the thread. Reply to
this email directly, view it on GitHub[1], or mute the thread[2].

Links:

  1. #1811 (comment)
    2.
    https://github.com/notifications/unsubscribe/AADItVLI8bbhQqFrxCfU6ZXtxy7TonHTks5qVhw1gaJpZM4JMVKg


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#1811 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADgNPBABaNYDLLQ-6QejNfzBMInK9q_ks5qViWSgaJpZM4JMVKg
.

Member

forki commented Jul 14, 2016

Ok. It looks reasonable

On Jul 14, 2016 2:03 PM, "Robert Pickering" notifications@github.com
wrote:

It adds LicenseUrl to type InstallModel, I needed it in the public api,
I thought others might too.

On Thu, Jul 14, 2016, at 01:23 PM, Steffen Forkmann wrote:

what's the prupose of this?
— You are receiving this because you authored the thread. Reply to
this email directly, view it on GitHub[1], or mute the thread[2].

Links:

  1. #1811 (comment)
    2.
    https://github.com/notifications/unsubscribe/AADItVLI8bbhQqFrxCfU6ZXtxy7TonHTks5qVhw1gaJpZM4JMVKg


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#1811 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADgNPBABaNYDLLQ-6QejNfzBMInK9q_ks5qViWSgaJpZM4JMVKg
.

@forki forki merged commit 4af89e3 into fsprojects:master Jul 14, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment