Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't allow empty string as description - take II #1831
Jul 25, 2016
referenced this pull request
Jul 25, 2016
Sorry for the inconvenience, @richard-green, but I think this change is needed. Packages with any of
@biehlermi and I had a hard time figuring out why NuGet based test adapters didn't work in a project of ours. The reason was a package created with Paket, which broke VSs discovery process.
See also themotleyfool/Klondike#158.
@forki, I would rather let Paket fail, because a warning message is easily overseen in the output of a build script. It also clearly indicates the cause of the failure, instead of an error later in the process, like in themotleyfool/Klondike#158. But I also agree that this is kind of breaking.
We could still give it a default description generated from the id and
On Jul 25, 2016 8:04 PM, "Ilja Nosik" email@example.com wrote:
As @inosik mentioned in https://github.com/themotleyfool/Klondike/issues/158, description is an obligatory field. I'm not a friend of soft fixes. They are almost always a pitfall for anyone who does not know about this.