New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrapper: fixed partial download #1859

Merged
merged 2 commits into from Aug 22, 2016

Conversation

Projects
None yet
2 participants
@Allon-Guralnek

For some reason, when downloading using the three-parameter DownloadFile method (which was only used by the GitHubDownloadStrategy), it only downloaded a partial file. The simpler two-parameter overload (used by NugetDownloadStrategyTests) always downloaded a full file. It seems the stream.CopyTo() used in the three-parameter overload doesn't work well. I removed the problematic overload (which wasn't needed anyway, the simpler one is better). Now Paket always downloads files correctly for me.

Allon-Guralnek added some commits Aug 17, 2016

Fixed downloading of partial files.
Commit by Allon Guralnek <allon.gu@gigya-inc.com>
On branch: refs/heads/Bootstrapper_FixPartialDownload
Fixed tests. Removed unused method.
Commit by Allon Guralnek <allon.gu@gigya-inc.com>
On branch: refs/heads/Bootstrapper_FixPartialDownload

@forki forki merged commit 8d164e7 into fsprojects:master Aug 22, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Aug 22, 2016

Member

cool thanks

Member

forki commented Aug 22, 2016

cool thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment