New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change project file condition handling to be case-insensitive #1890

Merged
merged 4 commits into from Aug 26, 2016

Conversation

Projects
None yet
2 participants
@amazingant
Contributor

amazingant commented Aug 25, 2016

Had to fiddle with the test a bit because one of the test projects uses the given build configuration as part of its output path, but this should fix #1889.

amazingant added some commits Aug 25, 2016

Try odd capitalization in ``should detect output path for proj file``
Test fails currently because output path detected does not match
configuration name perfectly
Adjust output path test to convert results to lowercase first
`Project1.fsprojtest` specifies its output path as
`bin\$(Configuration)\`, which means that the exact configuration passed
in will be the result. However, the other test project files have
hard-coded output paths. This handles both cases.
@amazingant

This comment has been minimized.

Show comment
Hide comment
@amazingant

amazingant Aug 25, 2016

Contributor

Uhh, soo, travis is out of disk space?

Contributor

amazingant commented Aug 25, 2016

Uhh, soo, travis is out of disk space?

Use OrdinalIgnoreCase in project file condition handling
Per @cloudRoutine, it's faster than InvariantCultureIgnoreCase is, and
still makes this code case-insensitive.
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Aug 25, 2016

Member

I'm not sure with which person I have to sleep with to get this bigger.

Member

forki commented Aug 25, 2016

I'm not sure with which person I have to sleep with to get this bigger.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Aug 26, 2016

Member

regarding mono build issue: travis-ci/travis-ci#6524

Member

forki commented Aug 26, 2016

regarding mono build issue: travis-ci/travis-ci#6524

@forki forki merged commit 0ddc394 into fsprojects:master Aug 26, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment