New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Nuget V3 API and async caching #1892

Merged
merged 2 commits into from Aug 26, 2016

Conversation

Projects
None yet
2 participants
@Thorium
Member

Thorium commented Aug 26, 2016

Better Nuget V3 API and async caching.
Public API and Nuget V2 API calls to Async.RunSynchronously should be still refactored away to be real async, but those would cause function signature changes and for that reason bigger refactoring.

Thorium added some commits Aug 26, 2016

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Aug 26, 2016

Member

so what is doing? or what was the problem?

Member

forki commented Aug 26, 2016

so what is doing? or what was the problem?

@Thorium

This comment has been minimized.

Show comment
Hide comment
@Thorium

Thorium Aug 26, 2016

Member

getNuGetV3Resource function was doing network fetching but:

  • getNuGetV3Resource errors were swallowed also in verbose mode. Not after this commit.
  • cache was not thread-safe. After this commit it is.
  • network operation was sync, not async. Because "Async.RunSynchronously" is actually sync. It's still sync.
Member

Thorium commented Aug 26, 2016

getNuGetV3Resource function was doing network fetching but:

  • getNuGetV3Resource errors were swallowed also in verbose mode. Not after this commit.
  • cache was not thread-safe. After this commit it is.
  • network operation was sync, not async. Because "Async.RunSynchronously" is actually sync. It's still sync.
@Thorium

This comment has been minimized.

Show comment
Hide comment
@Thorium

Thorium Aug 26, 2016

Member

The build is already failing before this...

Member

Thorium commented Aug 26, 2016

The build is already failing before this...

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Aug 26, 2016

Member

💋

Member

forki commented Aug 26, 2016

💋

@forki forki merged commit 5f749f4 into fsprojects:master Aug 26, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment