New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont publish .netcore temp nuget packages #1911

Merged
merged 1 commit into from Sep 5, 2016

Conversation

Projects
None yet
3 participants
@enricosada
Collaborator

enricosada commented Sep 5, 2016

the PublishNuGet task now delete the temp dotnetcore nuget packages before paket push

tested locally and package list to publish is ok

        Could not push package e:\github\Paket\temp\Paket.PowerShell.3.19.0.nupkg due to missing credentials for the url https://nuget.org/api/v2/package. Please specify a NuGet API key via the command line, the environment variable "nugetkey", or by using 'paket config add-token'.
Paket failed with:
        Could not push package e:\github\Paket\temp\Paket.Core.3.19.0.nupkg due to missing credentials for the url https://nuget.org/api/v2/package. Please specify a NuGet API key via the command line, the environment variable "nugetkey", or by using 'paket config add-token'.
Paket version 3.19.0.0
Paket failed with:
        Could not push package e:\github\Paket\temp\Paket.3.19.0.nupkg due to missing credentials for the url https://nuget.org/api/v2/package. Please specify a NuGet API key via the command line, the environment variable "nugetkey", or by using 'paket config add-token'.

and temp/dotnetcore nuget pkg are deleted

@enricosada enricosada referenced this pull request Sep 5, 2016

Merged

Dotnetcore build for Paket.Core #1785

8 of 8 tasks complete
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 5, 2016

Member

.net restore failed. sigh

Member

forki commented Sep 5, 2016

.net restore failed. sigh

@forki forki merged commit 1f78cf5 into fsprojects:master Sep 5, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Sep 5, 2016

Member

how is paket push behavior defined? does it randomly choose the first matching nupkg it finds?

I think it should have errored out in this case withou pushung anything...

Member

matthid commented Sep 5, 2016

how is paket push behavior defined? does it randomly choose the first matching nupkg it finds?

I think it should have errored out in this case withou pushung anything...

@enricosada

This comment has been minimized.

Show comment
Hide comment
@enricosada

enricosada Sep 5, 2016

Collaborator

@matthid i think fake just it tried to pushing all packages and nuget.org used last package.

let packages = !! (parameters.WorkingDir @@ "/**/*.nupkg") |> Seq.toList

maybe a safety check on names?

Collaborator

enricosada commented Sep 5, 2016

@matthid i think fake just it tried to pushing all packages and nuget.org used last package.

let packages = !! (parameters.WorkingDir @@ "/**/*.nupkg") |> Seq.toList

maybe a safety check on names?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment