Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate binding redirect that covers entire range of possible assembly versions #1932

Merged
merged 1 commit into from Oct 4, 2016

Conversation

dmitryvk
Copy link

Fixes #1930

@forki
Copy link
Member

forki commented Sep 30, 2016

there are couple of broken integration tests. Could you please try to fix these as well?

@dmitryvk
Copy link
Author

Yes, I will (actually, I just tried to fix them once and a little surprised that they failed).

@dmitryvk
Copy link
Author

dmitryvk commented Oct 3, 2016

There is now one failing test remains (and an timeout-caused error) but I don't think it's related:

Paket.IntegrationTests.InstallSpecs.#1270 install net461
  Expected string length 4623 but was 5057. Strings differ at index 3952.
  Expected: "...ifier) == '.NETFramework' And ($(TargetFrameworkVersion) =..."
  But was:  "...ifier) == '.NETFramework' And $(TargetFrameworkVersion) ==..."
  --------------------------------------------^

@forki forki merged commit f619b49 into fsprojects:master Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants