New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate binding redirect that covers entire range of possible assembly versions #1932

Merged
merged 1 commit into from Oct 4, 2016

Conversation

Projects
None yet
2 participants
@dmitryvk

Fixes #1930

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 30, 2016

Member

there are couple of broken integration tests. Could you please try to fix these as well?

Member

forki commented Sep 30, 2016

there are couple of broken integration tests. Could you please try to fix these as well?

@dmitryvk

This comment has been minimized.

Show comment
Hide comment
@dmitryvk

dmitryvk Sep 30, 2016

Yes, I will (actually, I just tried to fix them once and a little surprised that they failed).

Yes, I will (actually, I just tried to fix them once and a little surprised that they failed).

@dmitryvk

This comment has been minimized.

Show comment
Hide comment
@dmitryvk

dmitryvk Oct 3, 2016

There is now one failing test remains (and an timeout-caused error) but I don't think it's related:

Paket.IntegrationTests.InstallSpecs.#1270 install net461
  Expected string length 4623 but was 5057. Strings differ at index 3952.
  Expected: "...ifier) == '.NETFramework' And ($(TargetFrameworkVersion) =..."
  But was:  "...ifier) == '.NETFramework' And $(TargetFrameworkVersion) ==..."
  --------------------------------------------^

dmitryvk commented Oct 3, 2016

There is now one failing test remains (and an timeout-caused error) but I don't think it's related:

Paket.IntegrationTests.InstallSpecs.#1270 install net461
  Expected string length 4623 but was 5057. Strings differ at index 3952.
  Expected: "...ifier) == '.NETFramework' And ($(TargetFrameworkVersion) =..."
  But was:  "...ifier) == '.NETFramework' And $(TargetFrameworkVersion) ==..."
  --------------------------------------------^

@forki forki merged commit f619b49 into fsprojects:master Oct 4, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment