New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate-include-script should not #r FSharp.Core.dll #1946

Merged
merged 1 commit into from Oct 10, 2016

Conversation

Projects
None yet
2 participants
@smoothdeveloper
Contributor

smoothdeveloper commented Oct 7, 2016

Add test case and fix implementation

Fixes #1942

generate-include-script should not #r FSharp.Core.dll
Add test case and fix implementation
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Oct 7, 2016

Member

/cc @dsyme

Member

forki commented Oct 7, 2016

/cc @dsyme

@smoothdeveloper

This comment has been minimized.

Show comment
Hide comment
@smoothdeveloper

smoothdeveloper Oct 7, 2016

Contributor

@forki this PR failed to pass integration due to timeout on appveyor, do you have a way to run it again?

Contributor

smoothdeveloper commented Oct 7, 2016

@forki this PR failed to pass integration due to timeout on appveyor, do you have a way to run it again?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Oct 9, 2016

Member

I think easiest way is to push a new commit (which clean up or zero diff)

Member

forki commented Oct 9, 2016

I think easiest way is to push a new commit (which clean up or zero diff)

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Oct 10, 2016

Member

thanks!

Member

forki commented Oct 10, 2016

thanks!

@forki forki merged commit 34701eb into fsprojects:master Oct 10, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment