New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Verbose bootstrapper #2007

Merged
merged 4 commits into from Nov 10, 2016

Conversation

Projects
None yet
2 participants
@vbfox
Contributor

vbfox commented Nov 6, 2016

This PR change the way -s work in the bootstrapper. There is now a verbosity level that can be decreased via -s and increased via -v.

The levels are :

  • Silent -> Never display anything.
  • ErrorsOnly -> Only errors are shown on the console (Default in magic mode)
  • Normal -> Informative logs (Default in non-magic mode)
  • Trace -> More logs, especially timing for most operation is displayed.

This PR change the default behavior, before a single -s resulted in the boostrapper being silent but 2 are now needed for the same result

vbfox added some commits Nov 2, 2016

Add a concept of 'Verbosity' in the boostrapper
It replace the 'Silent' that was present before. Verbosity can be lowered
by one or more '-s' and raised by one or more '-v'.

This commit also change the behavior of the boostrapper when called with a
single '-s' argument, it's now displaying errors only instead of being
totally silent (A second '-s' is now necessary for that)
More trace logs including times for each strategy method
There are now a lot more logs in trace mode. A base class for all download
strategies is now taking care of logging execution start & time for all
methods.
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 9, 2016

Member

can you please make it compile with older C#? I have trouble in VS2013

Member

forki commented Nov 9, 2016

can you please make it compile with older C#? I have trouble in VS2013

@forki forki merged commit 3302f68 into fsprojects:master Nov 10, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment