New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of Git dependency change detection #2061

Merged
merged 2 commits into from Dec 1, 2016

Conversation

Projects
None yet
2 participants
@tomasdeml
Contributor

tomasdeml commented Nov 30, 2016

Change detection of Git dependencies does not work correctly for two or more dependencies as their RemoteFileChanges have Name set to "". This causes mismatch of dependencies during change detection. This PR fixes the bug by including remote's Origin in comparison.

tomasdeml added some commits Nov 30, 2016

Entries in dependencies and lock files are matched correctly when the…
…re are multiple git dependencies (as each has Name = '')

@forki forki merged commit 3fd7a95 into fsprojects:master Dec 1, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 1, 2016

Member

thanks!

Member

forki commented Dec 1, 2016

thanks!

@tomasdeml tomasdeml deleted the tomasdeml:git-dependency-change-detection-bug branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment