New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package names are compared using non-linguistic Ordinal comparison #2067

Merged
merged 1 commit into from Dec 4, 2016

Conversation

Projects
None yet
2 participants
@tomasdeml
Contributor

tomasdeml commented Dec 4, 2016

Test ParserSpecs.should parse lock file with depdencies fails under OS with Czech regional settings because of linguistic comparison of Chessie package name. In Czech, ch is a diagraph that is inserted between H and I letters in collation order. I fixed the issue by using non-linguistic ordinal comparison.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 4, 2016

Member

cool. thanks a lot!

Member

forki commented Dec 4, 2016

cool. thanks a lot!

@forki forki merged commit 44c91c5 into fsprojects:master Dec 4, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@tomasdeml tomasdeml deleted the tomasdeml:package-name-comparison-bug branch Dec 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment