New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGetV2-OData: retrieve versions in descending order for artifactory #2073

Merged
merged 2 commits into from Dec 12, 2016

Conversation

2 participants
@cdrnet
Member

cdrnet commented Dec 9, 2016

Related to #2008 which was reverted in #2018 because it affected non-artifactory servers negatively (in an unknown way).

This change adds an alternative variant of tryGetAllVersions to fetch the versions in descending order (by publish date) instead of modifying the original one.

GetVersions chooses to use the alternative variant in case the source URI contains the string "artifactory". This is a very unreliable way of discovering a server to be an artifactory one, but is in line with the existing rules and should prevent affecting non-artifactory servers.

Ideally the decision should be more controllable than URI matching, e.g. by introducing the concept of source options (explicitly in the dependencies and lock files).

cdrnet added some commits Dec 9, 2016

NuGetV2-OData: retrieve versions in descending order for artifactory
Related to #2008 which was reverted in #2018 because it affected non-artifactory
servers negatively (in an unknonwn way).

This change adds an alternative variant of tryGetAllVersions to fetch the
versions in descending order (by publish date) instead of modifying the
original one.

GetVersions chooses to use the alternative variant in case the source uri
contains the string "artifactory". This is a very unreliable way of
discovering a server to be an artifactory one, but is in line with the
existing rules and should prevent affecting non-artifactory servers.

Ideally the decision should be more controllable than url matching, e.g.
by introducing the concept of source options.
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 12, 2016

Member

thanks so much!

Member

forki commented Dec 12, 2016

thanks so much!

@forki forki merged commit 61f1040 into fsprojects:master Dec 12, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@cdrnet cdrnet deleted the cdrnet:artifactory-feed branch Dec 22, 2016

@matthid matthid added this to NuGet API & Performance in Breaking Changes Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment