New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One of the file writes was missing a Directory.Create() #2080

Merged
merged 2 commits into from Dec 15, 2016

Conversation

Projects
None yet
2 participants
@jamesjrg
Contributor

jamesjrg commented Dec 15, 2016

  1. generate-include-scripts used ToLowerInvariant() on the full path name which caused issues in Linux that wouldn't appear in Windows. Though apparently wasn't an issue on Macs? not sure why that would be, I don't have a mac.

  2. At first I thought the issue was the lack of Directory.Create() before File.WriteAllText for some files, but turned out this wasn't the issue due to file creation order meaning the directory was actually already there.

Regardless I changed it so in the function to write fsharp scripts it does a Directory.Create immediately before writing, which makes the functions to create fsharp and csharp scripts more consistent, and I think it's less confusing

  1. The Linux CI build is broken because of an issue with the .NET Core build, I have the same problem locally

@jamesjrg jamesjrg referenced this pull request Dec 15, 2016

Closed

Build error #1

jamesjrg added some commits Dec 14, 2016

Always Directory.Create() immediately before File.WriteAllText
This wasn't actually causing a bug but this makes the functions to create
fsharp and csharp scripts more consistent, and it's confusing if the code
relies on file creation order for fsharp scripts but not csharp scripts
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 15, 2016

Member

thanks!

Member

forki commented Dec 15, 2016

thanks!

@forki forki merged commit b957295 into fsprojects:master Dec 15, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment