New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove group with only remote files #2089

Merged
merged 2 commits into from Dec 19, 2016

Conversation

Projects
None yet
2 participants
@danielrbradley
Contributor

danielrbradley commented Dec 18, 2016

Created the test first and confirmed it failed. I've not yet had time to see if there are any similar bugs in other areas of the dependencies code - only taken a look at the removal case so far.

Edit: I've also added an extra fix for building on a path with spaces, though this still fails after due to a similar bug in the dotnet core targets file which I've reported here: dotnet/netcorecli-fsc#59

danielrbradley added some commits Dec 18, 2016

Add quoting of paths in Paket.Restore.targets
 - Fixes failure when path contains spaces.
 - Extracted restore command to separate MSBuild variable instead of having to
   XML attribute-escape the quotes.
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 19, 2016

Member

cool thx!

Member

forki commented Dec 19, 2016

cool thx!

@forki forki merged commit 8be653b into fsprojects:master Dec 19, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@danielrbradley danielrbradley deleted the danielrbradley:fix-group-removal branch Dec 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment