New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly escape no_proxy domains #2100

Merged
merged 1 commit into from Jan 2, 2017

Conversation

Projects
None yet
2 participants
@juergenhoetzel
Contributor

juergenhoetzel commented Dec 27, 2016

Bootstrapping fails on my setup, because I use wildcard in NO_PROXY:

→ echo $NO_PROXY 
*.fritz.box

→ ./obj/Debug/paket.bootstrapper.exe
Checking Paket version (downloading latest stable)...
The type initializer for 'Paket.Bootstrapper.EnvProxy' threw an exception. (Github - cached)

This is actually the same issue as #1939 which also need to be fixed in the bootstrapping code.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 2, 2017

Member

thanks!

Member

forki commented Jan 2, 2017

thanks!

@forki forki merged commit 7cfb73a into fsprojects:master Jan 2, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 2, 2017

Member

This broke one of the nunit bootstrapper tests. Please take a look at the appveyor build output (Travis is red for unrelated reason). Can you please send me a PR with a fix? Thanks

Member

forki commented Jan 2, 2017

This broke one of the nunit bootstrapper tests. Please take a look at the appveyor build output (Travis is red for unrelated reason). Can you please send me a PR with a fix? Thanks

juergenhoetzel added a commit to juergenhoetzel/Paket that referenced this pull request Jan 2, 2017

Fix bootstrapper test broken by #2100
The BypassList property contains an array of regular expressions.

forki added a commit that referenced this pull request Jan 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment