New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure stable ordering of references in the same ItemGroup #2105

Merged
merged 3 commits into from Jan 6, 2017

Conversation

Projects
None yet
2 participants
@flin-zap
Contributor

flin-zap commented Jan 6, 2017

No description provided.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 6, 2017

Member

It looks like you need to fix the tests

Member

forki commented Jan 6, 2017

It looks like you need to fix the tests

flin-zap added some commits Jan 6, 2017

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 6, 2017

Member

what was the error that lead to this?

Member

forki commented Jan 6, 2017

what was the error that lead to this?

@flin-zap

This comment has been minimized.

Show comment
Hide comment
@flin-zap

flin-zap Jan 6, 2017

Contributor

There were no errors, but we have a large c# solution, and every time we add a paket dependency to one of the projects and run "paket install", many of the other csproj files that have no dependency changes would have their references reordered

Contributor

flin-zap commented Jan 6, 2017

There were no errors, but we have a large c# solution, and every time we add a paket dependency to one of the projects and run "paket install", many of the other csproj files that have no dependency changes would have their references reordered

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 6, 2017

Member

Interesting. I wonder why that would happen.

Member

forki commented Jan 6, 2017

Interesting. I wonder why that would happen.

@forki forki merged commit 2ab6f63 into fsprojects:master Jan 6, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@flin-zap

This comment has been minimized.

Show comment
Hide comment
@flin-zap

flin-zap Jan 7, 2017

Contributor

Sorry it doesn't happen every time we add a paket dependency. it's probably quite niche, as I've been struggling to repro the issue on demand.

It could be a combination of changing project references + paket update that somehow changes the order of the references?

I just looked through the history of this file, a sortBy PATH was added on July 10 (fd3c3ac), and removed on August 12 (e580b8f). Do you know if that was intentional?

Contributor

flin-zap commented Jan 7, 2017

Sorry it doesn't happen every time we add a paket dependency. it's probably quite niche, as I've been struggling to repro the issue on demand.

It could be a combination of changing project references + paket update that somehow changes the order of the references?

I just looked through the history of this file, a sortBy PATH was added on July 10 (fd3c3ac), and removed on August 12 (e580b8f). Do you know if that was intentional?

@flin-zap

This comment has been minimized.

Show comment
Hide comment
@flin-zap

flin-zap Jan 7, 2017

Contributor

Here's a sample of a diff from before
image

Contributor

flin-zap commented Jan 7, 2017

Here's a sample of a diff from before
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment