New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make config writer use XmlWriter for disk write #2110

Merged
merged 1 commit into from Jan 18, 2017

Conversation

Projects
None yet
2 participants
@jdpage

jdpage commented Jan 17, 2017

... instead of doing XmlWriter -> string -> disk.

  • This guarantees that the file encoding and the XML declaration are
    properly in sync.
  • Adds a saveNormalizedXml function to Utils to facilitate this.
  • Adds a test to UtilsSpecs for the new function.
  • Updates ConfigFile.saveConfigNode to use the new function.
  • Should fix #2003 more permanently.
  • Removes the previous fix in commit d1d06b7
Jonathan Page
Make config writer use XmlWriter for disk write
... instead of doing XmlWriter -> string -> disk.
- This guarantees that the file encoding and the XML declaration are
  properly in sync.
- Adds a `saveNormalizedXml` function to Utils to facilitate this.
- Adds a test to UtilsSpecs for the new function.
- Updates ConfigFile.saveConfigNode to use the new function.
- Should fix #2003 permanently.
- Removes the previous fix in commit d1d06b7
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 18, 2017

Member

cool. thanks!

Member

forki commented Jan 18, 2017

cool. thanks!

@forki forki merged commit 243adb2 into fsprojects:master Jan 18, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment