New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A fix proposal for - Convert from nuget: Local package source give false error #1794 #2112

Merged
merged 10 commits into from Jan 24, 2017

Conversation

Projects
None yet
3 participants
@johannesvorster
Contributor

johannesvorster commented Jan 18, 2017

I was able to track down the error I was getting on my computer for issue #1794.

The problem was that the path string that was pass to the Directory.Exists function had double quotes at the start and beginning.

I tested it on a Windows 10 computer, but was able to test it on a linux computer because of issue #1809 : Install problem recurred in Ubuntu.

I don't have access to a ios computer.

I hope it help.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 18, 2017

Member

/cc @theimowski could you please review this?

Member

forki commented Jan 18, 2017

/cc @theimowski could you please review this?

@theimowski

This comment has been minimized.

Show comment
Hide comment
@theimowski

theimowski Jan 18, 2017

Member

Looks OK, wondering whether we could add this to normalizePath utility? Also can we get rid of changes in solution and project file? Those seem irrelevant

Member

theimowski commented Jan 18, 2017

Looks OK, wondering whether we could add this to normalizePath utility? Also can we get rid of changes in solution and project file? Those seem irrelevant

@johannesvorster

This comment has been minimized.

Show comment
Hide comment
@johannesvorster

johannesvorster Jan 18, 2017

Contributor

Thanks for the feed back. Will move it to normalizePath utility and remove the changes in the solution and prject files. I was wondering about the changes that was introduced for testing on my computer.

Contributor

johannesvorster commented Jan 18, 2017

Thanks for the feed back. Will move it to normalizePath utility and remove the changes in the solution and prject files. I was wondering about the changes that was introduced for testing on my computer.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 24, 2017

Member

thx!

Member

forki commented Jan 24, 2017

thx!

@forki forki merged commit ce8990e into fsprojects:master Jan 24, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@johannesvorster

This comment has been minimized.

Show comment
Hide comment
@johannesvorster

johannesvorster Jan 24, 2017

Contributor
Contributor

johannesvorster commented Jan 24, 2017

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 24, 2017

Member

Cool and welcome.

Basically all open issues are available for all contributors. Some are really challenging and others are much easier. It's hard to tell sometimes without trying ;-)

Member

forki commented Jan 24, 2017

Cool and welcome.

Basically all open issues are available for all contributors. Some are really challenging and others are much easier. It's hard to tell sometimes without trying ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment