New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitHub dependencies with spaces #2127

Merged
merged 6 commits into from Jan 29, 2017

Conversation

Projects
None yet
2 participants
@inosik
Contributor

inosik commented Jan 28, 2017

This should enable support for GitHub dependencies which contain spaces in their file name.

Enclose file names with quotes
Also, test the new behavior.
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 28, 2017

Member

this doesn't compile!?

Member

forki commented Jan 28, 2017

this doesn't compile!?

@inosik

This comment has been minimized.

Show comment
Hide comment
@inosik

inosik Jan 28, 2017

Contributor

I always forget that String.Contains doesn't accept chars 😅

Contributor

inosik commented Jan 28, 2017

I always forget that String.Contains doesn't accept chars 😅

@inosik

This comment has been minimized.

Show comment
Hide comment
@inosik

inosik Jan 28, 2017

Contributor

Okay, I will look at the failing tests.

Contributor

inosik commented Jan 28, 2017

Okay, I will look at the failing tests.

@forki forki merged commit 6c38f14 into fsprojects:master Jan 29, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@inosik inosik deleted the inosik:bugfix/#2114-filenames-with-spaces branch Jan 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment