New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect multiple install errors before failing #2177

Merged
merged 3 commits into from Mar 9, 2017

Conversation

Projects
None yet
2 participants
@cloudRoutine
Member

cloudRoutine commented Mar 7, 2017

Needing to run install several times in a row to get one successive error is a tedious chore, instead let's collect them and return them all at once.

@cloudRoutine cloudRoutine changed the title from [WIP] collect multiple install errors before failing to collect multiple install errors before failing Mar 7, 2017

fix vs2017 installation bug
vs2017 fsproj use tools version 15 by default but do not use the new
msbuild format. Paket will now check for the 'Sdk' attribute to ensure
it's the new format, to make sure it adds package references to the
fproj when it's supposed to.
@cloudRoutine

This comment has been minimized.

Show comment
Hide comment
@cloudRoutine

cloudRoutine Mar 8, 2017

Member

@forki the last commit takes care of the bug I found yesterday.

Member

cloudRoutine commented Mar 8, 2017

@forki the last commit takes care of the bug I found yesterday.

@forki forki merged commit 1212680 into fsprojects:core3 Mar 9, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Mar 9, 2017

Member

Cool thanks. Can you please send another pull request that adds this to the release notes? Thx

BTW next week I want to go rc or even release paket 4

Member

forki commented Mar 9, 2017

Cool thanks. Can you please send another pull request that adds this to the release notes? Thx

BTW next week I want to go rc or even release paket 4

@cloudRoutine

This comment has been minimized.

Show comment
Hide comment
@cloudRoutine

cloudRoutine Mar 10, 2017

Member

@forki like this #2181 ?

Member

cloudRoutine commented Mar 10, 2017

@forki like this #2181 ?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Mar 10, 2017

Member
Member

forki commented Mar 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment