New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to SourceLink v2 #2200

Merged
merged 25 commits into from Apr 24, 2017

Conversation

Projects
None yet
2 participants
@ctaggart
Contributor

ctaggart commented Mar 25, 2017

This is work-in-progress. It hasn't been as easy as I was hoping. The current issue is that if I try to do a msbuild /t:build Paket.sln or msbuild /t:build Paket.fsproj after a msbuild /t:restore I run into this error:

---------------------------------------------------------------------
  1) Building C:\projects\paket\src\Paket\Paket.fsproj failed with exitcode 1.
  2) : C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Microsoft\NuGet\15.0\Microsoft.NuGet.targets(197,5): The project.json is referencing the project 'C:\projects\paket\src\Paket\Paket.Core\Paket.Core.fsproj', but an output path was not specified on an item in the ProjectReferencesCreatingPackages property.

As far as I can tell, it has something to do with NuGet/Home#4532

Essentially, all I want to do with MSBuild 15 is:

msbuild /t:restore Paket.sln
msbuild /t:build Paket.sln

The good news is if I limit it to just Paket.Core, it does work:

C:\Users\CameronTaggart\fs\Paket\src\Paket.Core [sourcelink2 ≡]> dotnet sourcelink print-json "C:\Users\CameronTaggart\Downloads\bin\Paket.Core.pdb"
{"documents":{"C:\\projects\\paket\\*":"https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/*"}}

C:\Users\CameronTaggart\fs\Paket\src\Paket.Core [sourcelink2 ≡]> dotnet sourcelink print-urls "C:\Users\CameronTaggart\Downloads\bin\Paket.Core.pdb"
ed4678f7c9fe6396b80fbcd4033ea784 md5 fsharp C:\projects\paket\src\Paket.Core\SemVer.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/SemVer.fs
2c2b3a0f5f57dae031bd6e2775d7a8ea md5 fsharp C:\projects\paket\src\Paket.Core\VersionRange.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/VersionRange.fs
5d17cffaa21e4d21af04af3d13d4584f md5 fsharp C:\projects\paket\src\Paket.Core\Cache.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Cache.fs
e621330114b421f7bf23acd0cda5cb2d md5 fsharp C:\projects\paket\src\Paket.Core\FrameworkHandling.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/FrameworkHandling.fs
9240126c67b045dee9bcc13f6538a0fc md5 fsharp C:\projects\paket\src\Paket.Core\Nuspec.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Nuspec.fs
ccae66d219f275ca353adcba2848cc6c md5 fsharp C:\projects\paket\src\Paket.Core\InstallModel.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/InstallModel.fs
2a65218aec078af0cd093fa66005e22d md5 fsharp C:\projects\paket\src\Paket.Core\DependenciesTypes.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/DependenciesTypes.fs
bb3cef5044dd073cd46c46fd197da6d8 md5 fsharp C:\projects\paket\src\Paket.Core\Files\ReferencesFile.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Files/ReferencesFile.fs
45b4441ea83c65aa9f47afdadfcfa08a md5 fsharp C:\projects\paket\src\Paket.Core\Files\SolutionFile.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Files/SolutionFile.fs
f88cd9406d5eb14c059885e3334de415 md5 fsharp C:\projects\paket\src\Paket.Core\Files\LockFile.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Files/LockFile.fs
c25b8ac28928234b17cf3b8cf8ef36b4 md5 fsharp C:\projects\paket\src\Paket.Core\Files\TemplateFile.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Files/TemplateFile.fs
762f1e426210fd0901507f58209bb9f2 md5 fsharp C:\projects\paket\src\Paket.Core\Files\ProjectFile.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Files/ProjectFile.fs
795a36a04bdc3d8fdc26dcdd1d4d52c4 md5 fsharp C:\projects\paket\src\Paket.Core\Files\DependenciesFile.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Files/DependenciesFile.fs
159de3696bba8689832fc15884f26d20 md5 fsharp C:\projects\paket\src\Paket.Core\LocalFile.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/LocalFile.fs
d6040aade85f3d37e7eb5f6b740dec7b md5 fsharp C:\projects\paket\src\Paket.Core\ProcessOptions.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/ProcessOptions.fs
76be30eb682d4b16c7dedf513acd4906 md5 fsharp C:\projects\paket\src\Paket.Core\Environment.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Environment.fs
8b198137729af3d72a9d7e61d13c50b2 md5 fsharp C:\projects\paket\src\Paket.Core\PublicAPI.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/PublicAPI.fs
30fdfad30263da17b26ac2978b02a2a5 md5 fsharp C:\projects\paket\src\Paket.Core\Why.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Why.fs
875664d32b60d54ff473d65eb8b04bd6 md5 fsharp C:\projects\paket\src\Paket.Core\FindReferences.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/FindReferences.fs
a7c478d586e093d39fe92cf70e5072ae md5 fsharp C:\projects\paket\src\Paket.Core\FindOutdated.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/FindOutdated.fs
c3f87f08ea32af0afa2e590711800b97 md5 fsharp C:\projects\paket\src\Paket.Core\NugetConvert.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/NugetConvert.fs
3e9d6af258f5616c1f6095f085c3e947 md5 fsharp C:\projects\paket\src\Paket.Core\VSIntegration.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/VSIntegration.fs
32256342877512d9c7241346c7dccfeb md5 fsharp C:\projects\paket\src\Paket.Core\Simplifier.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Simplifier.fs
49167b5be9757b9c569c2213cd746807 md5 fsharp C:\projects\paket\src\Paket.Core\Releases.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Releases.fs
31a147c260a0990879884777ca128727 md5 fsharp C:\projects\paket\src\Paket.Core\PackageProcess.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/PackageProcess.fs
019c0a07fe279b4b44f66a8d2da91c87 md5 fsharp C:\projects\paket\src\Paket.Core\PackageMetaData.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/PackageMetaData.fs
cea47f36e25cdde3ec41eb16b83919b8 md5 fsharp C:\projects\paket\src\Paket.Core\AddProcess.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/AddProcess.fs
bc47f2bba55fb0a093bded64b3615da5 md5 fsharp C:\projects\paket\src\Paket.Core\RemoveProcess.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/RemoveProcess.fs
b4ec6fe2e9646754e31383d2a479c35c md5 fsharp C:\projects\paket\src\Paket.Core\UpdateProcess.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/UpdateProcess.fs
c8dce93f1404dd0675ebb1bded1d29e5 md5 fsharp C:\projects\paket\src\Paket.Core\InstallProcess.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/InstallProcess.fs
bde085b4392cfb30f00f73967ea393b0 md5 fsharp C:\projects\paket\src\Paket.Core\DependencyModel.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/DependencyModel.fs
df481b02dc05687ddb82774c9256b329 md5 fsharp C:\projects\paket\src\Paket.Core\NupkgWriter.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/NupkgWriter.fs
7b3afcdca7588930bccf9a5551ff720a md5 fsharp C:\projects\paket\src\Paket.Core\BindingRedirects.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/BindingRedirects.fs
5dd5df11679ffa1b02e07781baed9253 md5 fsharp C:\projects\paket\src\Paket.Core\RestoreProcess.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/RestoreProcess.fs
d24d4189f4d687f491cfc76e75da33ec md5 fsharp C:\projects\paket\src\Paket.Core\GarbageCollection.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/GarbageCollection.fs
b43d1512d86cac097668b5e17eec8c9a md5 fsharp C:\projects\paket\src\Paket.Core\DependencyChangeDetection.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/DependencyChangeDetection.fs
905862503260e69779b4b7b5af87fd9e md5 fsharp C:\projects\paket\src\Paket.Core\ScriptGeneration.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/ScriptGeneration.fs
b2523ce56b1668898a55d9df0f51388c md5 fsharp C:\projects\paket\src\Paket.Core\Queries.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Queries.fs
c5e69bd3687cbaaf8a0ec7ff62dd1f2a md5 fsharp C:\projects\paket\src\Paket.Core\NuGetV2.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/NuGetV2.fs
236997760df5f29640fa9a9fada05ac7 md5 fsharp C:\projects\paket\src\Paket.Core\NuGetV3.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/NuGetV3.fs
6e27729fed2c257e7c49bc636ca795db md5 fsharp C:\projects\paket\src\Paket.Core\Nuget.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Nuget.fs
8461ef8f60f002bcf834f8ecc787ae5a md5 fsharp C:\projects\paket\src\Paket.Core\Files\PackagesConfigFile.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Files/PackagesConfigFile.fs
def4d02c9756e72e42902e88977404b5 md5 fsharp C:\projects\paket\src\Paket.Core\Parsers\DependenciesFileParser.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Parsers/DependenciesFileParser.fs
3e2219e1397db447a7c41ecfca8622db md5 fsharp C:\projects\paket\src\Paket.Core\PackageResolver.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/PackageResolver.fs
efe3de40f397f0980cb47f181dd6a851 md5 fsharp C:\projects\paket\src\Paket.Core\RemoteUpload.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/RemoteUpload.fs
75a23ff12584fcd1a8244a2800d2889d md5 fsharp C:\projects\paket\src\Paket.Core\RemoteDownload.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/RemoteDownload.fs
fe782acce1a7d4e6fe8909cf41e716c7 md5 fsharp C:\projects\paket\src\Paket.Core\ModuleResolver.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/ModuleResolver.fs
195244ff45b5d729b1631e22926a9a2a md5 fsharp C:\projects\paket\src\Paket.Core\Requirements.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Requirements.fs
09d18e1598137ed8acd4dcb5fdcda75a md5 fsharp C:\projects\paket\src\Paket.Core\PlatformMatching.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/PlatformMatching.fs
439850ee9272f996c2e22605d877e6ae md5 fsharp C:\projects\paket\src\Paket.Core\PackageSources.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/PackageSources.fs
ec52fd7daec95bb97484c00b86eb0c4b md5 fsharp C:\projects\paket\src\Paket.Core\Cultures.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Cultures.fs
939a16872f512c847fcc11d13fb761a5 md5 fsharp C:\projects\paket\src\Paket.Core\ConfigFile.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/ConfigFile.fs
3e1f7178805f2caedd838f8278a459ea md5 fsharp C:\projects\paket\src\Paket.Core\GitHandling.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/GitHandling.fs
6a24cdeeef65ebd46a3813d5e01e393e md5 fsharp C:\projects\paket\src\Paket.Core\GitCommandHelper.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/GitCommandHelper.fs
f1227b3a60b66ad862a430673d1a706c md5 fsharp C:\projects\paket\src\Paket.Core\Xml.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Xml.fs
c2eca438f86c789308249337be3955ca md5 fsharp C:\projects\paket\src\Paket.Core\Utils.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Utils.fs
8c77ecd2695d617a27aff5778e67f79a md5 fsharp C:\projects\paket\src\Paket.Core\Constants.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Constants.fs
9f2c4fbc1fb55c5079149a6349a197d0 md5 fsharp C:\projects\paket\src\Paket.Core\Logging.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Logging.fs
29fed10e7f9a5987f854956ad922ce4a md5 fsharp C:\projects\paket\src\Paket.Core\Domain.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Domain.fs
027e02f806af194f1d6d32178f673369 md5 fsharp C:\projects\paket\src\Paket.Core\Async.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/Async.fs
43344be7465a330ca6145cf1f6064a2f md5 fsharp C:\projects\paket\paket-files\fsharp\FAKE\src\app\FakeLib\Globbing\Globbing.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/paket-files/fsharp/FAKE/src/app/FakeLib/Globbing/Globbing.fs
a9cbad1993fdbfdbf6aa1a1dd1b822b5 md5 fsharp C:\projects\paket\paket-files\fsprojects\FSharp.TypeProviders.StarterPack\src\AssemblyReader.fs
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/paket-files/fsprojects/FSharp.TypeProviders.StarterPack/src/AssemblyReader.fs
 00000000-0000-0000-0000-000000000000 fsharp C:\projects\paket\src\Paket.Core\unknown
https://raw.githubusercontent.com/ctaggart/Paket/0910a5678cb1542217efc61dfddfcf2c2d32cc6b/src/Paket.Core/unknown

I do not know what the unknown is. The source files aren't being checked, so F# must be doing something different then @(Compile). There is also an AccessViolation bug I'll have to troubleshoot with sourcelink test.

ctaggart added some commits Mar 27, 2017

source link for Paket.Core working
built and released SourceLink 2.1
has SourceLink.Create.CommnadLine
wrote EmbedPaketFiles target
@ctaggart

This comment has been minimized.

Show comment
Hide comment
@ctaggart

ctaggart Apr 1, 2017

Contributor

It works! This is the first real F# project that I've updated to use SourceLink 2.

dotnet sourcelink test "C:\Users\CameronTaggart\Downloads\bin (1)\Paket.Core.pdb"
sourcelink test passed: C:\Users\CameronTaggart\Downloads\bin (1)\Paket.Core.pdb

To be meaningful, you will need to include the Paket.Core.pdb in the nupkg. The two paket-files get embedded in that pdb since they are not in your repository. This commit makes MSBuild 15 required for SourceLink to work. Earlier versions of MSBuild should still work, but the MSBuildRelease probably needs an additional condition of isMSBuild15 or something like that then.

See http://blog.ctaggart.com/2017/03/enable-source-link-support-announcing.html
& https://github.com/ctaggart/SourceLink for updated docs.

Contributor

ctaggart commented Apr 1, 2017

It works! This is the first real F# project that I've updated to use SourceLink 2.

dotnet sourcelink test "C:\Users\CameronTaggart\Downloads\bin (1)\Paket.Core.pdb"
sourcelink test passed: C:\Users\CameronTaggart\Downloads\bin (1)\Paket.Core.pdb

To be meaningful, you will need to include the Paket.Core.pdb in the nupkg. The two paket-files get embedded in that pdb since they are not in your repository. This commit makes MSBuild 15 required for SourceLink to work. Earlier versions of MSBuild should still work, but the MSBuildRelease probably needs an additional condition of isMSBuild15 or something like that then.

See http://blog.ctaggart.com/2017/03/enable-source-link-support-announcing.html
& https://github.com/ctaggart/SourceLink for updated docs.

@ctaggart ctaggart changed the title from [WIP] switch to SourceLink v2 to switch to SourceLink v2 Apr 1, 2017

@ctaggart

This comment has been minimized.

Show comment
Hide comment
@ctaggart

ctaggart Apr 1, 2017

Contributor

Instead of portable, you could use a debug type of embedded to embed the debug info in Paket.Core.dll. That works too.

Contributor

ctaggart commented Apr 1, 2017

Instead of portable, you could use a debug type of embedded to embed the debug info in Paket.Core.dll. That works too.

Show outdated Hide outdated src/Directory.Build.props
</PropertyGroup>
<ItemGroup>
<PackageReference Include="SourceLink.Create.CommandLine" Version="2.1.0" PrivateAssets="all" />
<PackageReference Include="Microsoft.NuGet.Build.Tasks.Workaround" Version="*" PrivateAssets="all" />

This comment has been minimized.

@ctaggart

ctaggart Apr 1, 2017

Contributor

workaround for mixed msbuild projects like this for current MSBuild 15 NuGet/Home#4532

@ctaggart

ctaggart Apr 1, 2017

Contributor

workaround for mixed msbuild projects like this for current MSBuild 15 NuGet/Home#4532

Condition="$([System.String]::Copy('%(Identity)').Contains('paket-files'))" />
</ItemGroup>
<CreateProperty Value="@(EmbeddedFiles)">
<Output TaskParameter="Value" PropertyName="embed" />

This comment has been minimized.

@ctaggart

ctaggart Apr 1, 2017

Contributor

This embeds the paket-files in the pdb since they are not in the repository. csharp and vb support @(EmbeddedFiles) with relative directories, but not fsharp. This would work with all of them.

@ctaggart

ctaggart Apr 1, 2017

Contributor

This embeds the paket-files in the pdb since they are not in the repository. csharp and vb support @(EmbeddedFiles) with relative directories, but not fsharp. This would work with all of them.

@ctaggart

This comment has been minimized.

Show comment
Hide comment
@ctaggart
Contributor

ctaggart commented Apr 1, 2017

ctaggart added some commits Apr 13, 2017

woraround not needed anymore
is fixed in Visual Studio 2017 15.1 (26403.00)
https://www.appveyor.com/updates/
@ctaggart

This comment has been minimized.

Show comment
Hide comment
@ctaggart

ctaggart Apr 20, 2017

Contributor

Can I get a review please?

Contributor

ctaggart commented Apr 20, 2017

Can I get a review please?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 21, 2017

Member

Yes will take a look at it next week after vacation. Thanks for the work.

Member

forki commented Apr 21, 2017

Yes will take a look at it next week after vacation. Thanks for the work.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 24, 2017

Member

Thanks for your work!

Member

forki commented Apr 24, 2017

Thanks for your work!

@forki forki merged commit 5de5ff2 into fsprojects:master Apr 24, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ctaggart added a commit to ctaggart/Paket that referenced this pull request May 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment