New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix rotating app.config entries when generating redirects #2230

Merged
merged 1 commit into from Apr 12, 2017

Conversation

Projects
None yet
2 participants
@gimpf

gimpf commented Apr 11, 2017

An older commit termed "cleanup" seems to have inadvertently broken app.config binding redirects; they work, but on every paket install the order of the redirects is rotated, that is, the first one is moved to the last one (or the other way round).

This makes diffs more verbose than necessary, so I patched that out.

Tests still missing, but is it otherwise OK?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 11, 2017

Member

can you please add a comment that making it strict is important!?

Member

forki commented Apr 11, 2017

can you please add a comment that making it strict is important!?

@gimpf

This comment has been minimized.

Show comment
Hide comment
@gimpf

gimpf Apr 11, 2017

of course ;-)

gimpf commented Apr 11, 2017

of course ;-)

@forki forki merged commit 2a0c329 into fsprojects:master Apr 12, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gimpf gimpf deleted the gimpf:rotating-binding-redirects branch Nov 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment