New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] fix 2263: Framework restriction is lost for global build folder #2272

Merged
merged 6 commits into from Apr 24, 2017

Conversation

Projects
None yet
2 participants
@0x53A
Contributor

0x53A commented Apr 23, 2017

ref #2263

0x53A added some commits Apr 23, 2017

fix #2263
use group framework restrictions to decide if a package is global or fw-specific
Show outdated Hide outdated src/Paket.Core/Files/ProjectFile.fs
@@ -1079,7 +1079,7 @@ module ProjectFile =
let importTargets = defaultArg installSettings.ImportTargets true
let allFrameworks = applyRestrictionsToTargets ((thirdOf3 kv.Value)) KnownTargetProfiles.AllProfiles
let allFrameworks = applyRestrictionsToTargets ((thirdOf3 kv.Value)) (KnownTargetProfiles.AllDotNetStandardProfiles @ KnownTargetProfiles.AllDotNetProfiles)

This comment has been minimized.

@0x53A

0x53A Apr 23, 2017

Contributor

PLEASE REVIEW: I think we don't care about runtimes when deciding whether to install a .targets / .props, is that correct?

@0x53A

0x53A Apr 23, 2017

Contributor

PLEASE REVIEW: I think we don't care about runtimes when deciding whether to install a .targets / .props, is that correct?

This comment has been minimized.

@0x53A

0x53A Apr 23, 2017

Contributor

ref #2238

@0x53A

0x53A Apr 23, 2017

Contributor

ref #2238

@0x53A

This comment has been minimized.

Show comment
Hide comment
@0x53A

0x53A Apr 23, 2017

Contributor

Test failure:

 	System.dll!System.Uri.CreateThis(string uri, bool dontEscape, System.UriKind uriKind) + 0x105 bytes	
 	System.dll!System.Uri.Uri(string uriString) + 0x16 bytes	
>	Paket.Core.dll!Paket.Utils.createRelativePath(string root, string path) Line 163 + 0x18 bytes	F#
 	Paket.Core.dll!Paket.ProjectFileModule.globalTargetsNodes@930-4.Invoke(string path) Line 930 + 0x10 bytes	F#

image


The issue is that during these unit tests, the paths are already relative:

image


BUT during a real install, they are absolute:

image

Contributor

0x53A commented Apr 23, 2017

Test failure:

 	System.dll!System.Uri.CreateThis(string uri, bool dontEscape, System.UriKind uriKind) + 0x105 bytes	
 	System.dll!System.Uri.Uri(string uriString) + 0x16 bytes	
>	Paket.Core.dll!Paket.Utils.createRelativePath(string root, string path) Line 163 + 0x18 bytes	F#
 	Paket.Core.dll!Paket.ProjectFileModule.globalTargetsNodes@930-4.Invoke(string path) Line 930 + 0x10 bytes	F#

image


The issue is that during these unit tests, the paths are already relative:

image


BUT during a real install, they are absolute:

image

0x53A added some commits Apr 23, 2017

update baselines.
I HAVENT ACTUALLY VERIFIED THE CHANGES

@forki forki merged commit d6a4271 into fsprojects:master Apr 24, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@0x53A

This comment has been minimized.

Show comment
Hide comment
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 24, 2017

Member
Member

forki commented Apr 24, 2017

@0x53A

This comment has been minimized.

Show comment
Hide comment
@0x53A

0x53A Apr 24, 2017

Contributor

that's why the PR was still tagged [WIP] =)

Contributor

0x53A commented Apr 24, 2017

that's why the PR was still tagged [WIP] =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment