New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with ignored argument of getPackageDetails #2293

Merged
merged 2 commits into from Apr 27, 2017

Conversation

Projects
None yet
2 participants
@eugene-g
Contributor

eugene-g commented Apr 27, 2017

The argument "force" of getPackageDetails was ignored. PR fixes that issue by propagating argument to tryV2 and tryV3 functions.

Initially discussed here.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 27, 2017

Member

Something is red here

Member

forki commented Apr 27, 2017

Something is red here

@forki forki merged commit 9629f05 into fsprojects:master Apr 27, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eugene-g

This comment has been minimized.

Show comment
Hide comment
@eugene-g

eugene-g Apr 27, 2017

Contributor

@forki I was planning to install VS2015 later today to dig into red tests (currently, project doesn't build on VS2017).

Is it fine now or I should proceed?

Contributor

eugene-g commented Apr 27, 2017

@forki I was planning to install VS2015 later today to dig into red tests (currently, project doesn't build on VS2017).

Is it fine now or I should proceed?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 27, 2017

Member

I think it was unrelated

Member

forki commented Apr 27, 2017

I think it was unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment