New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Conditional Group Dependencies not working as expected #2335

Merged
merged 5 commits into from May 14, 2017

Conversation

Projects
None yet
2 participants
@matthid
Member

matthid commented May 13, 2017

@matthid matthid changed the title from add failing test to Fix Conditional Group Dependencies not working as expected May 13, 2017

| _ ->
dict.Add(packageName,v)
dict.Add(packageName,(v,hasCondition))

This comment has been minimized.

@matthid

matthid May 13, 2017

Member

here are the relevant changes...

@matthid

matthid May 13, 2017

Member

here are the relevant changes...

| true,(v',hasCondition') ->
if v' = v then
traceWarnfn "Package %O is referenced through multiple groups in %s (inspect lockfile for details). To resolve this warning use a single group for this project to get a unified dependency resolution or use conditions on the groups if you know what you are doing." packageName project.FileName
false

This comment has been minimized.

@matthid

matthid May 13, 2017

Member

We can argue about this warning, but I think it's the correct thing to do...

@matthid

matthid May 13, 2017

Member

We can argue about this warning, but I think it's the correct thing to do...

This comment has been minimized.

@matthid

matthid May 13, 2017

Member

/cc @agross This basically means you get this warning on your example from #1458. IMHO we should not encourage this kind of paket group usage.

@matthid

matthid May 13, 2017

Member

/cc @agross This basically means you get this warning on your example from #1458. IMHO we should not encourage this kind of paket group usage.

This comment has been minimized.

@matthid
@matthid

matthid May 14, 2017

Member
@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid May 14, 2017

Member

Apparently we broke the CI with 5e9c716 (because the error message was changed only in the code, not in the test). Maybe we should have a similar test running on travis as well?
For now I'll just go ahaid and fix it as part of this PR...

Member

matthid commented May 14, 2017

Apparently we broke the CI with 5e9c716 (because the error message was changed only in the code, not in the test). Maybe we should have a similar test running on travis as well?
For now I'll just go ahaid and fix it as part of this PR...

| DependenciesFile _ ->
loop tl (errorReport.AppendLinef " - Dependencies file requested package %O: %s%s" req.Name vr pr)
| Package (parentName,version,_) ->
loop tl (errorReport.AppendLinef " - %O %O requested package %O: %s%s" parentName version req.Name vr pr)

This comment has been minimized.

@matthid

matthid May 14, 2017

Member

req here is a bug, right?

@matthid

matthid May 14, 2017

Member

req here is a bug, right?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki May 14, 2017

Member
Member

forki commented May 14, 2017

@matthid matthid merged commit 4350a84 into master May 14, 2017

2 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid May 14, 2017

Member

AppVeyor seems kind of slow today, but I don't think the timeouts are related to the changes in this PR...

Member

matthid commented May 14, 2017

AppVeyor seems kind of slow today, but I don't think the timeouts are related to the changes in this PR...

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid May 14, 2017

Member

Or we introduced some change which makes everything slower recently ...

Member

matthid commented May 14, 2017

Or we introduced some change which makes everything slower recently ...

@matthid matthid deleted the fix_razorEngine_465 branch Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment