New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade to tooling 1.0 #2380

Merged
merged 6 commits into from Jun 1, 2017

Conversation

Projects
None yet
2 participants
@0x53A
Contributor

0x53A commented May 29, 2017

@0x53A

This comment has been minimized.

Show comment
Hide comment
@0x53A

0x53A May 29, 2017

Contributor

I didn't run any tests locally, let's see what the CI says.

Contributor

0x53A commented May 29, 2017

I didn't run any tests locally, let's see what the CI says.

@0x53A

This comment has been minimized.

Show comment
Hide comment
@0x53A

0x53A May 30, 2017

Contributor

@forki What's up with the build? :D

Contributor

0x53A commented May 30, 2017

@forki What's up with the build? :D

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid May 30, 2017

Member

Can you pick the MSBuild fixes from #2362?
Sorry #2362 is not ready to merge jet, and I need a couple of days to fix ... I will take care of it if you can't

Member

matthid commented May 30, 2017

Can you pick the MSBuild fixes from #2362?
Sorry #2362 is not ready to merge jet, and I need a couple of days to fix ... I will take care of it if you can't

@0x53A

This comment has been minimized.

Show comment
Hide comment
@0x53A

0x53A May 30, 2017

Contributor

I would prefer to just add the nuget FSharp.Compiler.Tools instead of hardcoding a few different paths. What do you think?

Contributor

0x53A commented May 30, 2017

I would prefer to just add the nuget FSharp.Compiler.Tools instead of hardcoding a few different paths. What do you think?

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid May 30, 2017

Member

Yes if it works I'm fine with that. nice!

Member

matthid commented May 30, 2017

Yes if it works I'm fine with that. nice!

@0x53A

This comment has been minimized.

Show comment
Hide comment
@0x53A

0x53A May 30, 2017

Contributor

Build now works, but one unit test failed. On it!

The great thing about the nuget is that this will allow compatibility with VS 2015 and F# vLatest. For example, if you use struct tuples, you will get red squiggles in the ide, but can still build and run / debug.

Contributor

0x53A commented May 30, 2017

Build now works, but one unit test failed. On it!

The great thing about the nuget is that this will allow compatibility with VS 2015 and F# vLatest. For example, if you use struct tuples, you will get red squiggles in the ide, but can still build and run / debug.

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid May 30, 2017

Member

Yes very nice! btw you can test with the appveyor artefact how this change will impact your scenario (sorry i'm on mobile today and tomorrow...) or just build locally obviously

Member

matthid commented May 30, 2017

Yes very nice! btw you can test with the appveyor artefact how this change will impact your scenario (sorry i'm on mobile today and tomorrow...) or just build locally obviously

@0x53A

This comment has been minimized.

Show comment
Hide comment
@0x53A

0x53A May 30, 2017

Contributor

wp_ss_20170531_0001
Av is green, travis failed with a weird error.

Please review if the unit test changes are actually correct.

Contributor

0x53A commented May 30, 2017

wp_ss_20170531_0001
Av is green, travis failed with a weird error.

Please review if the unit test changes are actually correct.

@matthid

Yep everything looks fine, just some minor stuff. You can ignore the travis failure. I'm on that in my other PR

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jun 1, 2017

Member

Looks good. Travis failure is not related to this PR.
Merging because this fixes the build with MSBuild 15 in a particular nice way.

Member

matthid commented Jun 1, 2017

Looks good. Travis failure is not related to this PR.
Merging because this fixes the build with MSBuild 15 in a particular nice way.

@matthid matthid merged commit c82d68c into fsprojects:master Jun 1, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@0x53A 0x53A deleted the 0x53A:downgrade-netstandard branch Jun 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment