New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the bootstrapper search harder for the paket.dependencies file #2384

Merged
merged 4 commits into from Jun 2, 2017

Conversation

Projects
None yet
2 participants
@matthid
Member

matthid commented Jun 1, 2017

like paket is doing it.

@vbfox please review. In particular I don't like how we now parse the command line twice in order to set the verbosity (such that we can trace on errors when finding the dependencies file). A better idea is welcome.

I guess I still need to add a test for this (I'm first trying to get the FAKE build green again).

matthid added some commits Jun 1, 2017

@matthid matthid merged commit 96d8f11 into master Jun 2, 2017

2 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@vbfox

This comment has been minimized.

Show comment
Hide comment
@vbfox

vbfox Jun 2, 2017

Contributor

👍 on the LocateDependencies change for me that the annoying thing about the boostrapper: It does some of what paket does but we can't share the code

On the trace I don't see the double parsing (Might have read too fast) and having a way to early-log is good.

Contributor

vbfox commented Jun 2, 2017

👍 on the LocateDependencies change for me that the annoying thing about the boostrapper: It does some of what paket does but we can't share the code

On the trace I don't see the double parsing (Might have read too fast) and having a way to early-log is good.

@@ -23,9 +23,13 @@ static void Main(string[] args)
Console.CancelKeyPress += CancelKeyPressed;
var fileProxy = new FileSystemProxy();
var optionsBeforeDependenciesFile = ArgumentParser.ParseArgumentsAndConfigurations(args, ConfigurationManager.AppSettings,
Environment.GetEnvironmentVariables(), fileProxy, Enumerable.Empty<string>());
ConsoleImpl.Verbosity = optionsBeforeDependenciesFile.Verbosity;

This comment has been minimized.

@matthid

matthid Jun 2, 2017

Member

@vbfox This is what I mean, we call ParseArgumentsAndConfigurations again below with an additional argument (which is Empty here).

I'm pretty sure we could refactor this somehow, but I couldn't come up with a nice way without changing basically everything.

@matthid

matthid Jun 2, 2017

Member

@vbfox This is what I mean, we call ParseArgumentsAndConfigurations again below with an additional argument (which is Empty here).

I'm pretty sure we could refactor this somehow, but I couldn't come up with a nice way without changing basically everything.

This comment has been minimized.

@vbfox

vbfox Jun 2, 2017

Contributor

Maybe the check for the environment variable should be done directly at that level without calling the ArgumentParser.

Accepting that the only way to verbose-log the early/configuration part of the bootstrapper is the environment variable.

@vbfox

vbfox Jun 2, 2017

Contributor

Maybe the check for the environment variable should be done directly at that level without calling the ArgumentParser.

Accepting that the only way to verbose-log the early/configuration part of the bootstrapper is the environment variable.

@matthid matthid deleted the fix_bootstrapper_finding_dependencies branch Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment