New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor nuget #2410

Merged
merged 3 commits into from Jun 10, 2017

Conversation

Projects
None yet
2 participants
@matthid
Member

matthid commented Jun 10, 2017

Basically everything was in the NuGetV2 module.
Now the following is separated:

  • NuGetCache
  • NuGetLocal
  • NuGetV2
  • NuGetV3
  • Nuget <- This is the module used thoughout Paket code (with some exceptions) it provides type forwards that the other ones don't need to be opened.

This PR builds on top of #2362 (will be easier to review once I got #2362 green and merged it)

matthid added some commits Jun 10, 2017

@baronfel

Great effort, I really like the work to abstract away particular nuget versions. One minor question is all I have.

Show outdated Hide outdated src/Paket.Core/Dependencies/Nuget.fs

@matthid matthid merged commit 81e5673 into master Jun 10, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@matthid matthid deleted the refactor_nuget branch Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment