New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interactive package search #2424

Merged
merged 1 commit into from Jun 18, 2017

Conversation

Projects
None yet
3 participants
@agross
Contributor

agross commented Jun 15, 2017

Interactive package search currently searches for :q even though the user wants to exit the search:

$ mono bin/paket.exe find-packages
Paket version 5.0.0-rc008
 - Please enter search text (:q for exit):
fake
FAKE
FakeSign
Faker
FakeO
FakeHost
FakeData
FAKEX
FAKE.SQL
FAKE.IIS
FAKE.Lib
Fake.AWS
FakeN.Web
FSharp.FakeTargets
FakeHttp
FakeDb
FakeDbSet
FAKE.Core
FAKE.Gallio
Faker.Net
Sitecore.FakeDb
 - Please enter search text (:q for exit):
:q
Quartz
jQuery
jQuery.Validation
jQuery.UI.Combined
Microsoft.jQuery.Unobtrusive.Ajax
Microsoft.jQuery.Unobtrusive.Validation
AspNet.ScriptManager.jQuery
Q
QR
Qiwi
QB
QLIB
QB1
QLog
qunit
QKit
Qlue
QLSLib
Qi.Data
Qvc
Performance:
 - Average Request Time: 419 milliseconds
 - Number of Requests: 3
 - Runtime: 4 seconds
@matthid

I guess it works. Personally I'd prefer refactoring the code in a different way. Maybe tail recursive function?

Show outdated Hide outdated src/Paket/Program.fs
@agross

This comment has been minimized.

Show comment
Hide comment
@agross

agross Jun 16, 2017

Contributor

I have no idea whether this is tail recursive, but you were right, the code looks better.

Contributor

agross commented Jun 16, 2017

I have no idea whether this is tail recursive, but you were right, the code looks better.

@matthid

Nice!

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 18, 2017

Member

thx

Member

forki commented Jun 18, 2017

thx

@forki forki merged commit bb4fcf3 into fsprojects:master Jun 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@agross agross deleted the agross:fix-interactive-search branch Jul 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment