New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests 2436 #2439

Merged
merged 3 commits into from Jun 18, 2017

Conversation

Projects
None yet
2 participants
@matthid
Member

matthid commented Jun 18, 2017

While writing the tests I encountered some problems with the default StartAsTask implementation, which makes it not very useful for reporting the proper error.

Or maybe I'm just too stupid to use if properly.

matthid added some commits Jun 18, 2017

catch the correct exception :/. Add detailed errors to the test suite…
… and simplify Async.StartAsTaskTimeout to Async.StartAsTaskProperCancel.

@forki forki merged commit a90544c into master Jun 18, 2017

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@matthid matthid deleted the add_tests_2436 branch Jul 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment